Benchmark #475
Closed
IWANABETHATGUY
started this conversation in
Ideas
Benchmark
#475
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Benchmark
Old Solution
Firstly, we compile rspack to node binding via
napi-rs
and then bench our rspack using nodejs benchmark.We would expose the nodejs api to the user side finally, so using nodejs benchmark framework for performance monitoring makes sense.
But this solution has some downsides,
run benchmark twice without any code change:
1.5s is insane.
as we all know, the benchmark is a time costing task in CI workflow, triggering the benchmark every commit also extends our workflow.
New Solution
We keep the old nodejs benchmark as is. Some changes are listed below:
criterion
by default, triggering by hand via GitHub issue comment before you are ready to review (you could trigger any time as you want, usually we trigger it before reviewing).node_binding
crate in pull request, you should trigger the nodejs benchmark. (You could trigger both the rust benchmark and nodejs benchmark if you want)Beta Was this translation helpful? Give feedback.
All reactions