Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store Street View sidepanel's width after resizing #4

Open
3 of 4 tasks
Glodenox opened this issue Aug 15, 2019 · 1 comment
Open
3 of 4 tasks

Store Street View sidepanel's width after resizing #4

Glodenox opened this issue Aug 15, 2019 · 1 comment
Assignees

Comments

@Glodenox
Copy link
Collaborator

Glodenox commented Aug 15, 2019

With the recent addition to resize the sidepanel that contains the Street View imagery it would make sense to also store this position over sessions with a local storage variable. Right now it always defaults to just 50% of the width.

Things to account for:

  • window resizing (store data as a percentage value instead?)
  • listener might disappear when the WME enters another mode and the sidepanel gets regenerated
  • either don't store the data on each trigger or make sure storing the data is very lightweight as there might be a lot of triggers while dragging the panel
  • make sure that the street view pane doesn't need some sort of trigger so it knows it has been resized (check the Waze or Google code for this)
@Glodenox Glodenox self-assigned this Aug 15, 2019
@Glodenox
Copy link
Collaborator Author

Initial implementation added in version 0.8.0. To test further later on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant