Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Start widget maximized #1650

Open
jfmcdonald opened this issue Dec 29, 2024 · 2 comments
Open

[Feature]: Start widget maximized #1650

jfmcdonald opened this issue Dec 29, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@jfmcdonald
Copy link

Feature description

It would be helpful to have an option in the widget config to start the widget maximized rather then as a window.

Implementation Suggestion

addtion of a "cmd:maximized": "true" option in the widget config

Anything else?

No response

@jfmcdonald jfmcdonald added enhancement New feature or request triage Needs triage labels Dec 29, 2024
@esimkowitz esimkowitz added good first issue Good for newcomers and removed triage Needs triage labels Dec 29, 2024
@esimkowitz
Copy link
Member

esimkowitz commented Dec 29, 2024

This is very easy to do on the frontend, the LayoutTreeInsertNodeAction for the layout model already includes the magnified flag. For creating a new widget from the widget tab-bar, we could add a Cmd modifier for the click handler that passes the magnified: true flag when creating the new node in the layout. We could also add a Shift modifier that creates the new node as an ephemeral node using the LayoutModel.newEphemeralNode function.

For WSH, we could add a flag for the wsh editor and wsh web commands and any others that create a block. When they call wshclient.CreateBlockCommand, they can just pass the ephemeral or magnified flag

@RohitN002
Copy link

@esimkowitz @jfmcdonald I like to work in this could you please assign me this work ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants