Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: No blocks and no wsh installed #1629

Open
3 tasks
javawithrocky opened this issue Dec 25, 2024 · 12 comments
Open
3 tasks

[Bug]: No blocks and no wsh installed #1629

javawithrocky opened this issue Dec 25, 2024 · 12 comments
Labels
bug Something isn't working triage Needs triage

Comments

@javawithrocky
Copy link

Current Behavior

In watching intro videos online it seems like Wave has Warp like feature of each command and it's output is a block. That doesn't seem to be the case. Also, wsh is not available in Wave as well.

image

Expected Behavior

  1. wsh should be installed?
  2. I should be able to see and copy blocks like in Warp?

Steps To Reproduce

  1. Download Wave (v0.10.4)
  2. You won't see blocks
  3. wsh is not installed.

NOTE: I have 2019 Mac

Wave Version

v0.10.4

Platform

macOS

OS Version/Distribution

Sequoia 15.1.1

Architecture

x64

Anything else?

image

Questionnaire

  • I'm interested in fixing this myself but don't know where to start
  • I would like to fix and I have a solution
  • I don't have time to fix this right now, but maybe later
@javawithrocky javawithrocky added bug Something isn't working triage Needs triage labels Dec 25, 2024
@esimkowitz
Copy link
Member

Could you send your log file to [email protected]? You can find your logfile location by running wsh wavepath log from within Wave

@javawithrocky
Copy link
Author

Sure. Please find it attached.

waveapp.log

@esimkowitz
Copy link
Member

What shell are you using?

@javawithrocky
Copy link
Author

Fish shell. Sorry, I should have mentioned this earlier.

@andsty
Copy link

andsty commented Dec 27, 2024

having the same issue here on mac. also wsh cannot be installed on remote linux server i connect

Disconnected from "[email protected]@1.1.1.1"
unable to use wsh: timeout waiting for connserver to register
i get this message when i connect on a remote linux server

@Turney1337
Copy link

Partly the same issue on Ubuntu 24.04 - while wsh gets installed, locally as well as remote, there are no blocks present anywhere.

@sawka
Copy link
Member

sawka commented Dec 28, 2024

@javawithrocky thanks for your patience. been going through all the fish startup code, but I can't find the inconsistency (yet).

two things that would really help me figure this out is:

(1) if you could let me know what your $PATH is set to. echo $PATH (i'm curious if our wsh bin dir got added properly to your path).

(2) if you could do an ls -l "/Users/rhasija/Library/Application Support/waveterm/bin" (you'll need the quotes cause of the space in Application Support). i'd expect to see wsh in there. here's my output:

total 14280
-rwxr-xr-x@ 1 mike  staff  7308274 Dec 27 17:55 wsh

@javawithrocky
Copy link
Author

javawithrocky commented Dec 28, 2024

Sure thing:

~/L/A/waveterm [127] $ ls -l "/Users/rhasija/Library/Application Support/waveterm/bin"                                                                                                                     16:19:06
total 14784
-rwxr-xr-x@ 1 rhasija  staff  7567408 Dec 26 10:50 wsh*
~/L/A/waveterm $ echo $PATH                                                                                                                                                                                16:19:15
/Users/rhasija/.asdf/shims /usr/local/opt/asdf/libexec/bin /usr/local/opt/mysql-client/bin /usr/local/opt/m4/bin /Users/rhasija/.local/bin /Users/rhasija/.fig/bin /Users/rhasija/.cargo/bin /Users/rhasija/.nvm/versions/node/v12.22.1/bin /Users/rhasija/.local/share/fig/plugins/git-flow /usr/ucb /Users/rhasija/.sdkman/candidates/java/current/bin /Users/rhasija/.sdkman/candidates/kotlin/current/bin /Users/rhasija/.sdkman/candidates/maven/current/bin /Users/rhasija/.sdkman/candidates/gradle/current/bin /Users/rhasija/.sdkman/candidates/quarkus/current/bin /usr/local/go/bin /Users/rhasija/.fig/bin /Users/rhasija/.cargo/bin /usr/local/bin /usr/bin /bin /usr/sbin /sbin
~/L/A/waveterm $                                                                                                                                                                                           16:19:23

Once I added the path like below to ~/.config/fish/config.fish then wsh is found and it works:

set -gx PATH /Users/rhasija/Library/Application\ Support/waveterm/bin $PATH

So, it seems like the issue is as simple as PATH not being updated.

@javawithrocky
Copy link
Author

Hello, any updates on this? I am a bit worried that the issue will auto close if no activity occurs within a time frame.

Also any word in each command being a block? Is that no longer the case with Wave? Just want to understand what to expect.

@esimkowitz
Copy link
Member

esimkowitz commented Jan 1, 2025

Hi, we don't auto-close issues so no worries there, we're working on some general bug bashing in the shell detection code that may fix this, however due to the holidays, we're not going to be publishing a beta until probably next week.

We understand that there's mixed messaging here because of the existing coverage of our legacy app, but we do not currently support rendering each command as a separate block. This was a conscious decision to improve compatibility with more shell configurations as the old way we were doing this was breaking too many things for too many people and the feedback we were getting was that it wasn't helpful enough. We're looking into ways we can bring this back as an alternative display method, but I cannot give you a timeline for when it would return. If you have more questions about this, feel free to reach out to us on Discord or open a new Discussions thread, happy to discuss further there.

@javawithrocky
Copy link
Author

Hi,

I noticed the following text on the main GitHub page:

Command Blocks for isolating and monitoring individual commands with auto-close options

If "Command Blocks" is not a feature, even if temporarily, I recommend removing the reference. It could be confusing for new users and, at worst, might be perceived as misleading.

@esimkowitz
Copy link
Member

esimkowitz commented Jan 6, 2025

we're repurposing this term in the new app to refer to single-command widgets, which is a new feature in 0.10. It is not the same thing as the block-style command history from the old app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage Needs triage
Projects
None yet
Development

No branches or pull requests

5 participants