[Feature]: Customize default window size and zoom

[esimkowitz]

Feature description

Add a configuration to override the default new window size and zoom so users with larger/smaller monitors can get the best experience.

Implementation Suggestion

Add window:dimensions setting with a string value {X}x{Y} where the units are pixels. This can be applied in emain-window.ts when the Electron BaseWindow object gets initialized.

Add window:zoom setting with a float value that defaults to 1. This can be applied in emain-tabview.ts, where the WebContentsView gets initialized. This can be overridden by different tabs too.

Anything else?

No response

[zaidnadaff]

Hi, can I work on this?

[esimkowitz]

Of course! Assigning to you

[esimkowitz]

Updated the ask for window:zoom, to match what Electron expects, this should probably be a float value instead of an integer

[zaidnadaff]

Hey @esimkowitz I'm sorry for asking as I am new to this.

For the first part of making sure that window size gets overridden, a combination of ScaleFactor and relative views like percentage can be used? ScaleFactor makes sure that the physical and logical pixels of devices with different resolutions maintain a uniform view.

For the zoom, I did not quite what get the requirement is.

Also, I noticed another error, when zooming out, when I was pressing ctrl + '-' continuously, the app crashed.

this was fixed when I replaced this code

if (wc.getZoomFactor() <= 0.2) { return; } wc.setZoomFactor(wc.getZoomFactor() - 0.2);

with this

wc.setZoomFactor(Math.max(0.2, wc.getZoomFactor() - 0.2));

[esimkowitz]

Yeah that new logic makes sense to me, good catch! Could you do the same for the zoom in logic? Also could you consolidate those zoom functions in menu.ts so they don't duplicate logic?

[esimkowitz]

I think for the default zoom factor, it's just whatever the user defines is the default when a new window gets created and the value we set it back to when they use the Cmd:0 keyboard shortcut. We should let them still zoom in/out manually