Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

发现有处代码问题,希望对项目有帮助 #13

Open
wuaoya opened this issue Mar 28, 2022 · 0 comments
Open

发现有处代码问题,希望对项目有帮助 #13

wuaoya opened this issue Mar 28, 2022 · 0 comments

Comments

@wuaoya
Copy link

wuaoya commented Mar 28, 2022

类名:CalculateServiceFactory.java
版本:Latest commit [73cc707] on 8 Nov 2020
行数:33-38
问题:判断中使用了相同的条件,应该更正为其他策略。
片段: } else if (Constant.CalculateTypeEnum.SUBTRACT.getType().equals(type)) {
calculateService = subtractCalculateServiceImpl;
} else if (Constant.CalculateTypeEnum.SUBTRACT.getType().equals(type)) {
calculateService = multiplyCalculateServiceImpl;
} else if (Constant.CalculateTypeEnum.SUBTRACT.getType().equals(type)) {
calculateService = divideCalculateServiceImpl;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant