Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to rebuild for Windows #39

Open
giuppe opened this issue Apr 7, 2021 · 7 comments
Open

Unable to rebuild for Windows #39

giuppe opened this issue Apr 7, 2021 · 7 comments

Comments

@giuppe
Copy link

giuppe commented Apr 7, 2021

This is the same issue as openfl/lime#875 .

If you try to rebuild via lime rebuild systools windows, you get an error because of a missing reference to the sprintf function. That function was removed from default MSVC libs some years ago, to nudge developers into using more secure version of those functions (like sprintf_s)
https://docs.microsoft.com/en-us/cpp/c-runtime-library/secure-template-overloads?view=msvc-160

There are two possible fixes for this issue:

  • changing sprintf with sprintf_s in the code (there is only one instance of this);
  • adding legacy_stdio_definitions.lib to the linker: that would load the missing reference to sprintf

Edit: I did a PR with the second solution.

@ghost
Copy link

ghost commented Nov 7, 2021

what file is it that i need to put those lines of code?

@giuppe
Copy link
Author

giuppe commented Nov 7, 2021

@gummybear17 change project/build.xml like this: 36f4939

@ghost
Copy link

ghost commented Nov 7, 2021

hey uhh
i was was wondering if you can add me on discord

@ghost
Copy link

ghost commented Nov 7, 2021

?

@ghost
Copy link

ghost commented Nov 7, 2021

mine is Jonnycat#8275

@ghost
Copy link

ghost commented Nov 7, 2021

ok i did it you can now run the build go to my repository of it

@ghost
Copy link

ghost commented Nov 7, 2021

no self promote just telling him/her that the thing is fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant