Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Ansible with Bash script #303

Closed
ngosang opened this issue Oct 25, 2022 · 3 comments · Fixed by #307
Closed

Replace Ansible with Bash script #303

ngosang opened this issue Oct 25, 2022 · 3 comments · Fixed by #307

Comments

@ngosang
Copy link
Contributor

ngosang commented Oct 25, 2022

Removing the Ansible and Python packages from the Dockerfile:

  • We reduce the Docker image in 413 MB (595 MB -> 182 MB)

Converting the Ansible playbook into a Bash script:

  • We keep the same functionality
  • The Docker container startup time is reduced in +30 seconds

I can do the changes if you merge my other PRs first.

Related #269 #270
@j0k3r
Copy link
Member

j0k3r commented Oct 28, 2022

What do you think @wallabag/core?

@nicosomb
Copy link
Member

I think it should be a good idea and a good optimization. 💯

@ngosang
Copy link
Contributor Author

ngosang commented Oct 28, 2022

Ok, I will work on it this weekend.

Take a look and merge #265 #301 #302

@ngosang ngosang mentioned this issue Oct 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace Ansible with Shell script ngosang/docker
3 participants
@j0k3r @nicosomb @ngosang