Clarify when icecandidatepairremove is fired.
#204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvestrand
reviewed
May 16, 2024
| @@ -686,7 +686,21 @@ <h3> | |||
| The [= ICE agent =] will continue to send data using |candidatePair| until instructed to use another candidate pair with {{RTCIceTransport/selectCandidatePair}}. | |||
| </p> | |||
| <p> | |||
| When the [= ICE agent =] has picked a candidate pair to remove, the [= user agent =] MUST [= queue a task =] to <dfn | |||
| The [= ICE agent =] can decide to remove a candidate pair for several reasons. Examples include: | |||
There was a problem hiding this comment.
Suggested change
| The [= ICE agent =] can decide to remove a candidate pair for several reasons. Examples include: | |
| The [= ICE agent =] can decide to remove a candidate pair for several reasons. | |
| <p class="note"> Examples include: |
There was a problem hiding this comment.
Moved the entire text blurb into a non-normative note.
alvestrand
reviewed
May 16, 2024
jan-ivar
approved these changes
May 16, 2024
|
@sam-vi still seeing some validation errors. Do you need help on this one? |
dontcallmedom
force-pushed
the
196-ice-restart
branch
from
3ba38c7 to
184ce11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #196.
Enumerate examples of situations in which
icecandidatepairremoveis fired, including ICE restart.This makes it clear that the event is fired and
[[CandidatePairs]]is cleared in the event of an ICE restart.Preview | Diff