Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skipto needs to be updated to version 5.1.4 #2677

Closed
jongund opened this issue Apr 20, 2023 · 2 comments · Fixed by #2680
Closed

Skipto needs to be updated to version 5.1.4 #2677

jongund opened this issue Apr 20, 2023 · 2 comments · Fixed by #2680
Assignees
Labels
enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy Infrastructure Related to maintaining task force and repo operations, processes, systems, documentation

Comments

@jongund
Copy link
Contributor

jongund commented Apr 20, 2023

There is an issue with with Firefox browser when calculating the accessible name for a heading that includes an IMG element.
The bug has been fixed in version 5.1.4, not sure how to push the change to the APG template.

You can see the Firefox bug by opening the SkipTo menu in the Patterns Page. The names of headings that include images are prefixed with -Moz-alt-content. NOTE: This only happens in Firefox browser.

Link to new version of Script:
Skipto 5.1.4

More information on SkipTo 5.1.4

@mcking65 mcking65 added enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy Infrastructure Related to maintaining task force and repo operations, processes, systems, documentation labels Apr 25, 2023
@a11ydoer a11ydoer assigned jongund and unassigned mcking65 Apr 25, 2023
@alflennik
Copy link
Contributor

I opened a PR on the wai-aria-practices side which updates the library and will close this issue: w3c/wai-aria-practices#217 Thank you Jon for raising this and implementing the fix!

@mcking65
Copy link
Contributor

@alflennik

I commented in #2682 that I think it is best to continue sourcing skipto.js from content/shared/js in aria-practices. Merging #2680 should be the resolution to this issue of upgrading skipto.js.

At this point, I'm confused about the best strategy for eliminating duplication. Clearly, there is something about the build I don't yet sufficiently understand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy Infrastructure Related to maintaining task force and repo operations, processes, systems, documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants