From f0f40a6f07dfba8ee7f028b2c86f1e3377994748 Mon Sep 17 00:00:00 2001 From: Howard Edwards Date: Thu, 21 Nov 2024 12:19:51 -0500 Subject: [PATCH 01/17] Include link to Review Page from Test Run --- client/components/TestRun/Heading.js | 8 +++++++- client/components/TestRun/index.jsx | 9 ++++----- 2 files changed, 11 insertions(+), 6 deletions(-) diff --git a/client/components/TestRun/Heading.js b/client/components/TestRun/Heading.js index 9a25b6ac2..5ece8e9c6 100644 --- a/client/components/TestRun/Heading.js +++ b/client/components/TestRun/Heading.js @@ -24,6 +24,8 @@ const TestRunHeading = ({ openAsUser, showEditAtBrowser, testPlanTitle, + testPlanVersionString, + testPlanVersionReviewLink, testResults, testIndex, testCount, @@ -137,6 +139,7 @@ const TestRunHeading = ({ ); } + const testPlanName = `${testPlanTitle} ${testPlanVersionString}`; return ( <>
@@ -145,7 +148,8 @@ const TestRunHeading = ({ data-testid="apg-example-name" >
- Test Plan: {testPlanTitle} + Test Plan:  + {testPlanName}
@@ -177,6 +181,8 @@ const TestRunHeading = ({ TestRunHeading.propTypes = { testPlanTitle: PropTypes.string.isRequired, + testPlanVersionString: PropTypes.string.isRequired, + testPlanVersionReviewLink: PropTypes.string.isRequired, at: PropTypes.string.isRequired, browser: PropTypes.string.isRequired, showEditAtBrowser: PropTypes.bool.isRequired, diff --git a/client/components/TestRun/index.jsx b/client/components/TestRun/index.jsx index 144788fec..cefc80ff2 100644 --- a/client/components/TestRun/index.jsx +++ b/client/components/TestRun/index.jsx @@ -366,10 +366,7 @@ const TestRun = () => { issueLink = createIssueLink({ testPlanTitle: testPlanVersion.title, testPlanDirectory: testPlanVersion.testPlan.directory, - versionString: `V${dates.convertDateToString( - testPlanVersion.updatedAt, - 'YY.MM.DD' - )}`, + versionString: testPlanVersion.versionString, testTitle: currentTest.title, testRowNumber: currentTest.rowNumber, testSequenceNumber: currentTest.seq, @@ -969,7 +966,7 @@ const TestRun = () => {
@@ -277,7 +277,7 @@

- - + @@ -221,7 +221,7 @@

+ test + + + + {selectedIssueType === 'command' && ( + <> + Select command ... +
+ {currentTest.scenarios.map((scenario, index) => { + const commandKey = `${scenario.id}-${scenario.commands + .map(command => command.id) + .join('_')}`; + const commandText = scenario.commands + .map(command => command.text) + .join(' then '); + + return ( + + ); + })} +
+ + )} { if (!(testPlanDirectory || testPlanTitle || versionString || atName)) { throw new Error('Cannot create issue link due to missing parameters'); @@ -72,9 +74,15 @@ const createIssueLink = ({ titleStart = 'Feedback'; } - title = - `${titleStart}: "${testTitle}" (${testPlanTitle}, ` + - `Test ${testSequenceNumber}, ${versionString})`; + if (commandString) { + title = + `${titleStart}: "${testTitle}" (${testPlanTitle}, ` + + `Test ${testSequenceNumber}, Command "${commandString}", ${versionString})`; + } else { + title = + `${titleStart}: "${testTitle}" (${testPlanTitle}, ` + + `Test ${testSequenceNumber}, ${versionString})`; + } } else { title = `General Feedback: ${testPlanTitle} ${versionString}`; if (atName) title = `${atName} ${title}`; @@ -120,8 +128,13 @@ const createIssueLink = ({ `[${shortenedUrl}](${modifiedRenderedUrl})\n` + reportLinkFormatted + atFormatted + - browserFormatted + - '\n'; + browserFormatted; + + if (commandString) { + testSetupFormatted = `${testSetupFormatted}` + `- Command: ${commandString}\n`; + } + + testSetupFormatted = `${testSetupFormatted}\n`; } let metadataFormatted = ''; From f167097dd142d4735fe03d2919779fe9f7d440ac Mon Sep 17 00:00:00 2001 From: Howard Edwards Date: Mon, 16 Dec 2024 17:34:48 -0500 Subject: [PATCH 08/17] Update snapshots --- .../e2e/snapshots/saved/_data-management.html | 12 ++++++------ client/tests/e2e/snapshots/saved/_run_2.html | 19 ++++++++++++++++++- .../snapshots/saved/_test-plan-report_1.html | 19 ++++++++++++++++++- 3 files changed, 42 insertions(+), 8 deletions(-) diff --git a/client/tests/e2e/snapshots/saved/_data-management.html b/client/tests/e2e/snapshots/saved/_data-management.html index fc0f5d489..5c2317902 100644 --- a/client/tests/e2e/snapshots/saved/_data-management.html +++ b/client/tests/e2e/snapshots/saved/_data-management.html @@ -259,7 +259,7 @@

-

R&D -

Complete Aug 23, 2023

+

Complete Dec 12, 2024

@@ -2363,7 +2363,7 @@

Test Plans Status Summary

V23.08.23V24.12.12
+ id="basic-navbar-nav" + >
  • + viewBox="0 0 512 512" + > Signed in as joe-the-admin

    • + class="test-navigator-toggle-inner-container" + >

    @@ -121,14 +132,16 @@     @@ -302,7 +335,8 @@

    >
    + data-testid="apg-example-name" + >
    Test Plan: Select Only Combobox Example V22.03.17
    + data-testid="at-browser" + >
    AT: NVDA 2020.4
    @@ -322,7 +357,8 @@

    type="button" id="edit-fa-button" aria-label="Edit version details for AT and Browser" - class="btn btn-primary"> + class="btn btn-primary" + >

    @@ -348,10 +386,12 @@

    class="svg-inline--fa fa-check" role="img" xmlns="http://www.w3.org/2000/svg" - viewBox="0 0 448 512"> + viewBox="0 0 448 512" + > 18 of 21 tests completed

    @@ -389,7 +429,11 @@

    + class=" + test-plan-results-table + table table-bordered + " + > @@ -461,7 +505,11 @@

    F Results
    + class=" + test-plan-results-table + table table-bordered + " + > @@ -533,7 +581,11 @@

    C Results
    + class=" + test-plan-results-table + table table-bordered + " + > @@ -605,7 +657,11 @@

    Tab Results
    + class=" + test-plan-results-table + table table-bordered + " + > @@ -671,19 +727,22 @@

      + class="test-run-toolbar mt-1" + >
      • @@ -717,25 +778,9 @@

      Test Options

        -
      • - Raise an issue for ... -
        - -
        + aria-labelledby="test-options-heading" + > +
      • Test Options role="img" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 512 512" - color="#94979b"> + color="#94979b" + > Raise an Issue
        • @@ -763,7 +810,8 @@

        Test Options

        @@ -784,7 +834,8 @@

        Test Options

        @@ -817,7 +868,8 @@

        Test Options

        class="fade modal show" tabindex="-1" aria-labelledby="title-modal-2" - style="display: block; padding-left: 0px"> + style="display: block; padding-left: 0px" + >
    Down Arrow Results
    + class="test-plan-results-table table table-bordered"> @@ -505,11 +461,7 @@

    F Results
    + class="test-plan-results-table table table-bordered"> @@ -581,11 +533,7 @@

    C Results
    + class="test-plan-results-table table table-bordered"> @@ -657,11 +605,7 @@

    Tab Results
    + class="test-plan-results-table table table-bordered"> @@ -727,22 +671,19 @@

      + class="test-run-toolbar mt-1">
      • @@ -778,8 +717,7 @@

      Test Options

        + aria-labelledby="test-options-heading">
      • Test Options role="img" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 512 512" - color="#94979b" - > + color="#94979b"> Raise an Issue
        • @@ -810,8 +746,7 @@

        Test Options

        @@ -834,8 +767,7 @@

        Test Options

        @@ -868,8 +800,7 @@

        Test Options

        class="fade modal show" tabindex="-1" aria-labelledby="title-modal-2" - style="display: block; padding-left: 0px" - > + style="display: block; padding-left: 0px">
        @@ -1297,15 +1193,13 @@

        After 'Tab'

        type="radio" id="pass-3-1-yes" name="assertion-3-1" - data-testid="radio-yes-3-1" - />YesYesNo
        @@ -1315,15 +1209,13 @@

        After 'Tab'

        type="radio" id="pass-3-2-yes" name="assertion-3-2" - data-testid="radio-yes-3-2" - />YesYesNo
        @@ -1335,8 +1227,7 @@

        After 'Tab'

    Down Arrow Results