From a2bb3a20d7e902211e0dbb9c39fed3043597721e Mon Sep 17 00:00:00 2001 From: Anna Musial Date: Thu, 29 Jun 2023 12:15:33 +0200 Subject: [PATCH] fix!: changed paddings in sfselect (#2864) * fix: changed paddings in sfselect * chore: adjusted padding left * chore: updated changelog * Update .changeset/fresh-emus-care.md Co-authored-by: Jakub Freisler --------- Co-authored-by: Jakub Freisler --- .changeset/fresh-emus-care.md | 6 ++++++ .../sfui/frameworks/react/components/SfSelect/SfSelect.tsx | 2 +- .../sfui/frameworks/vue/components/SfSelect/SfSelect.vue | 2 +- 3 files changed, 8 insertions(+), 2 deletions(-) create mode 100644 .changeset/fresh-emus-care.md diff --git a/.changeset/fresh-emus-care.md b/.changeset/fresh-emus-care.md new file mode 100644 index 0000000000..277858e08b --- /dev/null +++ b/.changeset/fresh-emus-care.md @@ -0,0 +1,6 @@ +--- +'@storefront-ui/react': major +'@storefront-ui/vue': major +--- + +Breaking Change - Padding left and right in SfSelect changed from 14px and 16px to 12px diff --git a/packages/sfui/frameworks/react/components/SfSelect/SfSelect.tsx b/packages/sfui/frameworks/react/components/SfSelect/SfSelect.tsx index 2bc94059d0..4d0c779ad5 100644 --- a/packages/sfui/frameworks/react/components/SfSelect/SfSelect.tsx +++ b/packages/sfui/frameworks/react/components/SfSelect/SfSelect.tsx @@ -45,7 +45,7 @@ export default function SfSelect(props: SfSelectProps) { required={required} disabled={disabled} className={classNames( - 'appearance-none disabled:cursor-not-allowed cursor-pointer pl-4 pr-3.5 text-neutral-900 focus:ring-primary-700 focus:ring-2 outline-none bg-transparent rounded-md ring-1 ring-inset ring-neutral-300 hover:ring-primary-700 active:ring-2 active:ring-primary-700 disabled:bg-disabled-100 disabled:text-disabled-900 disabled:ring-disabled-200', + 'appearance-none disabled:cursor-not-allowed cursor-pointer px-3 text-neutral-900 focus:ring-primary-700 focus:ring-2 outline-none bg-transparent rounded-md ring-1 ring-inset ring-neutral-300 hover:ring-primary-700 active:ring-2 active:ring-primary-700 disabled:bg-disabled-100 disabled:text-disabled-900 disabled:ring-disabled-200', { 'py-1.5': size === SfSelectSize.sm, 'py-2': size === SfSelectSize.base, diff --git a/packages/sfui/frameworks/vue/components/SfSelect/SfSelect.vue b/packages/sfui/frameworks/vue/components/SfSelect/SfSelect.vue index 1d0b1d2a14..dcfa6b0218 100644 --- a/packages/sfui/frameworks/vue/components/SfSelect/SfSelect.vue +++ b/packages/sfui/frameworks/vue/components/SfSelect/SfSelect.vue @@ -73,7 +73,7 @@ const changedValue = (event: Event) => { :required="required" :disabled="disabled" :class="[ - 'appearance-none disabled:cursor-not-allowed cursor-pointer pl-4 pr-3.5 text-neutral-900 ring-inset focus:ring-primary-700 focus:ring-2 outline-none bg-transparent rounded-md ring-1 ring-neutral-300 hover:ring-primary-700 active:ring-2 active:ring-primary-700 disabled:bg-disabled-100 disabled:text-disabled-900 disabled:ring-disabled-200', + 'appearance-none disabled:cursor-not-allowed cursor-pointer px-3 text-neutral-900 ring-inset focus:ring-primary-700 focus:ring-2 outline-none bg-transparent rounded-md ring-1 ring-neutral-300 hover:ring-primary-700 active:ring-2 active:ring-primary-700 disabled:bg-disabled-100 disabled:text-disabled-900 disabled:ring-disabled-200', { 'py-1.5': size === SfSelectSize.sm, 'py-2': size === SfSelectSize.base,