Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Service 리팩토링 #1

Open
vsh123 opened this issue Sep 9, 2019 · 0 comments
Open

refactor: Service 리팩토링 #1

vsh123 opened this issue Sep 9, 2019 · 0 comments
Assignees

Comments

@vsh123
Copy link
Owner

vsh123 commented Sep 9, 2019

ArticleInnerService가 필요한가요?
그냥 바이패스하는 서비스로 보이는데
ArticleInnerService를 ArticleService로,
사용하는 측에서 ArticleService와 ArticleLikeService를 사용하면 안되나요?
의존은 Article에 대한 기능들은 느슨하게 가져가지만 ArticleService의 관심사가 많은건 변함 없어보이네요. :)
ArticleService와 마찬가지로 CommentLikeService와 CommentService를 별도로 사용하면 되지 않을까요?
단일 책임에 대해서 고민해보면 좋을 것 같아요.
@vsh123 vsh123 self-assigned this Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant