Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DirectFileManipulator Update? #6

Open
Laharah opened this issue Jun 20, 2024 · 1 comment
Open

DirectFileManipulator Update? #6

Laharah opened this issue Jun 20, 2024 · 1 comment

Comments

@Laharah
Copy link

Laharah commented Jun 20, 2024

I've been using livesync-bridge for a while but earlier this week I reset my couchdb and reset all the dbs in obsidian. I noticed that livesync-bridge no longer works, it's using the old replicate/pull urls to communicate with couchdb that are now returning a 404.

Digging through the source it looks like DirectFileManipulator is no longer compatible with the new database configuration? I'm not sure as I'm not super familiar with TS or this code base. I did see the todo comment about updating DirectFileManipulator to use LiveSyncDBFunction which makes me think I'm correct.

Looking at the current LiveSync replicators, it looks like they all use pouchdb, which isn't in livesync-bridge.

Are there any plans for updating this? If you know what you want to do and roughly how to do it I'd be happy to give it a shot and try and make a PR. Though your project looks very clean, and I'm not sure you'd want me messing it up with my awful TS 😁

If this doesn't belong here I can move this issue to the livesync-bridge issues page.

@vrtmrz
Copy link
Owner

vrtmrz commented Jun 21, 2024

Thank you for asking me!

Unfortunately, as you mentioned it lost the compatibilities for the extended configurations.

Now I am making three npm (or jsr) libraries.

Reinvented-wheels, Obsidian-facets, and, livesync-common.
All of them have the tests by vitest.

Indeed, it takes a bit of time. However, I believe that everything would get more rigidity and robustness after this work.

Back into the topic, all your contributions are always welcome! My TS codes were also so awful in the earlier phases. I will not think so about for your codes!

Of course, your contributions will be included into the these libraries.

If this doesn't belong here I can move this issue to the livesync-bridge issues page.

This has been caused the same reason that each libraries has not explicit responsibility. Do not mind to use either here or bridges repo.

Sorry for the rough reply from the mobile phone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants