Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it More Apparent that SECRET_KEY cannot be blank #978

Closed
ZaxLofful opened this issue Nov 15, 2023 · 3 comments · Fixed by #979
Closed

Make it More Apparent that SECRET_KEY cannot be blank #978

ZaxLofful opened this issue Nov 15, 2023 · 3 comments · Fixed by #979
Labels

Comments

@ZaxLofful
Copy link

ZaxLofful commented Nov 15, 2023

The main README doesn't say anything about how the value of SECRET_KEY cannot be blank. Nor does the documentation for Puppet show in the example that the key is needed to run.

When we attempt to run this container, it fails unless we add an arbitrary SECRET_KEY of any kind, but the documents don't say that.

Was able to figure it out by going through the code and seeing a comment that says:

# this empty string has to be changed, we validate it with check_secret_key()

This should be on the main page in bold letters, because it just doesn't work otherwsie.

@kenyon
Copy link
Member

kenyon commented Nov 15, 2023

The README does say something about it, but it doesn't say it can't be the empty string:

puppetboard/README.md

Lines 171 to 173 in bad3de6

- `SECRET_KEY`: set this to a long string, **the same for each application replica** and keep it secret. Refer to
[Flask documentation](https://flask.palletsprojects.com/en/2.1.x/quickstart/#sessions), section
"How to generate good secret keys" for more info.

Also, if you use the puppetboard module, this is handled for you.

@ZaxLofful
Copy link
Author

ZaxLofful commented Nov 16, 2023

Yeah, that's what I was implying. On the README make a part about that it cannot be blank. It took my DEV team about a week to figure out why it wasn't launching because its not clear from standard run guide.

Will look into the other solution as well.

@kenyon
Copy link
Member

kenyon commented Nov 16, 2023

See #979 for an update to the README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants