From c8bb7883ee7e8410bdc8545c387183b25f22e95d Mon Sep 17 00:00:00 2001 From: Tim Meusel Date: Thu, 6 Jun 2024 21:22:37 +0200 Subject: [PATCH 1/4] CI: build gem with --strict & --verbose --- .github/workflows/ci.yml | 2 +- .github/workflows/release.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index eb6a924..35b45bc 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -39,7 +39,7 @@ jobs: ruby-version: ${{ matrix.ruby }} bundler-cache: true - name: Verify gem builds - run: gem build *.gemspec + run: gem build --strict --verbose *.gemspec # Currently no tests are defined in this gem # - name: Run spec tests # run: bundle exec rake diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 2cce833..fcc9fbd 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -18,7 +18,7 @@ jobs: env: BUNDLE_WITHOUT: release - name: Build gem - run: gem build *.gemspec + run: gem build --strict --verbose *.gemspec - name: Publish gem to rubygems.org run: gem push *.gem env: From aae68a4f2d30d4711bfd88a219039af1e0d2e467 Mon Sep 17 00:00:00 2001 From: Tim Meusel Date: Fri, 7 Jun 2024 00:13:12 +0200 Subject: [PATCH 2/4] gemspec: Add version constraints --- beaker-google.gemspec | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/beaker-google.gemspec b/beaker-google.gemspec index 4492a87..fc6d832 100644 --- a/beaker-google.gemspec +++ b/beaker-google.gemspec @@ -24,13 +24,13 @@ Gem::Specification.new do |s| s.add_development_dependency 'pry', '~> 0.10' s.add_development_dependency 'rake', '~> 13.0' s.add_development_dependency 'rspec', '~> 3.0' - s.add_development_dependency 'rspec-its' - s.add_development_dependency 'simplecov' + s.add_development_dependency 'rspec-its', '~> 1.3' + s.add_development_dependency 'simplecov', '~> 0.22.0' s.add_development_dependency 'voxpupuli-rubocop', '~> 2.7.0' # Documentation dependencies - s.add_development_dependency 'thin' - s.add_development_dependency 'yard' + s.add_development_dependency 'thin', '~> 1.8', '>= 1.8.2' + s.add_development_dependency 'yard', '~> 0.9.36' # Run time dependencies s.add_runtime_dependency 'stringify-hash', '~> 0.0.0' From 195bfd0bb844c29e35ee6a5fd2aed88f02092c87 Mon Sep 17 00:00:00 2001 From: Tim Meusel Date: Fri, 7 Jun 2024 00:13:51 +0200 Subject: [PATCH 3/4] Add missing faraday dep This is an optional dependency for gcg. but we get an annoying warning if it's missing. --- Gemfile | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Gemfile b/Gemfile index cfd4a35..bdee17f 100644 --- a/Gemfile +++ b/Gemfile @@ -20,6 +20,7 @@ group :acceptance_testing do gem 'beaker', *location_for(ENV.fetch('BEAKER_VERSION', '~> 4.0')) end -group :release do - gem 'github_changelog_generator', require: false +group :release, optional: true do + gem 'faraday-retry', '~> 2.1', require: false + gem 'github_changelog_generator', '~> 1.16.4', require: false end From 6edd83068bf1fa0d802b52a263d1d1c13aaff972 Mon Sep 17 00:00:00 2001 From: Tim Meusel Date: Fri, 7 Jun 2024 00:18:14 +0200 Subject: [PATCH 4/4] beaker-google.gemspec: Fix license identifier --- beaker-google.gemspec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/beaker-google.gemspec b/beaker-google.gemspec index fc6d832..6bbc581 100644 --- a/beaker-google.gemspec +++ b/beaker-google.gemspec @@ -11,7 +11,7 @@ Gem::Specification.new do |s| s.homepage = 'https://github.com/voxpupuli/beaker-google' s.summary = 'Beaker DSL Extension Helpers!' s.description = 'Google Compute Engine support for the Beaker acceptance testing tool.' - s.license = 'Apache2' + s.license = 'Apache-2.0' s.files = `git ls-files`.split("\n") s.executables = `git ls-files -- bin/*`.split("\n").map { |f| File.basename(f) }