🐛 [Bug] Creature formation

[Stoabrogga]

🐛 Bug report

If you kill the leader of a creature formation with waypoint movement and leave combat, the rest of the formation will continue to follow the WP path. If you attack the formation later and the leader spawns during combat the formation members will run away, but you keep being in combat until you find the leader.

Expected behavior

The formation members should stay in combat and only run away to their leader if combat ends.

Steps to reproduce

I tested this with GUID 27114. Kill the leader, get out of combat and let the formation continue on its path, then attack them later while the leader respawns.

Version & Environment

Client Version: 1.12.1.5875

Commit Hash: 8d36d4d

OS Client: Ubuntu 24.04 (Wine)
OS Server: Ubuntu 22.04

Crashlog

• None

[Stoabrogga]

Here's a video where I provoked the issue using a GM account:
https://github.com/user-attachments/assets/11b60e6c-b511-4d4d-b22b-e4b09349a0f1

It seems to be caused by this line:

core/src/game/CreatureGroups.cpp

Line 159 in 8f379e7

otherMember->GetMotionMaster()->Initialize();

After the leader respawns, the movement of the formation members is initialized and they fall back into patrolling, despite being in combat. I don't know how to fix this correctly, but one solution could be to evade after the movement is initialized so they break combat and run back to their leader.