Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player movement is not 100% smooth #129

Open
dRaiNe opened this issue Jan 24, 2019 · 10 comments
Open

Player movement is not 100% smooth #129

dRaiNe opened this issue Jan 24, 2019 · 10 comments
Assignees
Labels
bug Something isn't working

Comments

@dRaiNe
Copy link

dRaiNe commented Jan 24, 2019

Current behavior:
See https://youtu.be/vBn_W8ppQOw?t=3 at 0:04. Player's position bounces slightly from time to time.
Expected behavior:
Players should move smoothly.
Steps to reproduce:

  1. Open 2 WoW Clients at the same time and log into 2 different accounts.
  2. Let first player stand still and second runs around like in the video above. Use windowed mode.
  3. Observe stuttering on localhost.

Client version:
1.12
Commit hash:

Operating system:
Windows 7 x64

@ratkosrb
Copy link
Contributor

The other servers in that video are not for vanilla, so its possible this is a flaw of the vanilla client.

@dRaiNe
Copy link
Author

dRaiNe commented Jan 24, 2019

No, it's not. I experienced this also with WotLK trinitycore some time ago. Notice all the 3 servers in the video have this problem. The Felmyst does it and the Warmane (TBC) seems ok in the video, but I tested on their server and believe they have the same issue, only the update diff is somewhat lower (so it's harder to spot).

For a split of a second, the player blinks from one location to another and then back immediately. See for example https://www.youtube.com/watch?v=VX7RuUcd-3Q&t=588s a blizz vanilla rogue. I don't believe he has the best latency all the time, yet player movements are smooth and this 'teleporting' never happened on the retail.

Also, it's only player movement problem. NPCs move smoothly all the time, no stuttering!

@Daribon
Copy link
Contributor

Daribon commented Jan 27, 2019

Can confirm, it's a serverside issue that exist on all vanilla and TBC emulators.

@Kittnz
Copy link
Contributor

Kittnz commented Jan 27, 2019

TrinityCore/TrinityCore#18771

@ratkosrb
Copy link
Contributor

For some reason, movement appears smoother on the 1.8.4 client.
https://streamable.com/qppp5

Now compare to the constant twitching with 1.12.
https://streamable.com/k9qvb

@arziraki
Copy link

Is this still being looked at? The movement is the only thing that is still immersion breaking.

@Kittnz
Copy link
Contributor

Kittnz commented May 21, 2019

I guess different movement packets @ratkosrb

@Test045
Copy link
Contributor

Test045 commented May 23, 2019

The twitching only happens when the player moves while also moving his camera.
One should see how we handle MSG_MOVE_SET_FACING (when already moving only)

EDIT : It's actually reproductible even with "turn camera" keybind (which sends a different packet than MSG_MOVE_SET_FACING), it's just harder to reproduce in that case for some reason.

@ulfgebhardt ulfgebhardt added the bug Something isn't working label Dec 31, 2020
@ulfgebhardt
Copy link
Collaborator

CMangos works on some movement packet parsing at the moment. Mind take a look @ratkosrb ?

@ratkosrb
Copy link
Contributor

Cmangos does not have this solved.

spirehawk pushed a commit to spirehawk/westfall that referenced this issue Mar 21, 2022
only 3 exist, right now, you can expect to be ambushed with almost every single pull you do
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

7 participants