From af586cbd3f5390ac44ab2b1eb724f7fead079ca1 Mon Sep 17 00:00:00 2001 From: Jonathan Matthew Date: Mon, 11 Aug 2014 07:46:42 +1000 Subject: [PATCH] replace GtkMisc xpad and ypad properties with margin-* margin-left and margin-right are deprecated too, but we can easily switch to margin-start and margin-end once the gtk+ requirement goes up. --- data/ui/general-prefs.ui | 100 +++++++++++++++++++++++---------------- data/ui/main-toolbar.ui | 45 +++++++++++------- data/ui/podcast-prefs.ui | 91 +++++++++++++++++++++-------------- data/ui/sync-dialog.ui | 35 ++++++++++---- widgets/rb-button-bar.c | 2 +- 5 files changed, 168 insertions(+), 105 deletions(-) diff --git a/data/ui/general-prefs.ui b/data/ui/general-prefs.ui index 38a41d3d7..0834a89ae 100644 --- a/data/ui/general-prefs.ui +++ b/data/ui/general-prefs.ui @@ -1,6 +1,7 @@ + - + True False @@ -48,7 +49,8 @@ True False - 8 + 8 + 8 False @@ -64,11 +66,12 @@ _Artists and albums + False True True False - False True + 0.5 True True @@ -82,11 +85,12 @@ _Genres and artists + False True True False - False True + 0.5 True library_browser_views_radio @@ -100,11 +104,12 @@ G_enres, artists and albums + False True True False - False True + 0.5 True library_browser_views_radio @@ -194,7 +199,8 @@ True False - 8 + 8 + 8 False @@ -214,124 +220,132 @@ Track _number + False True True False - False True + 0.5 True - + _Artist + False True True False - False True + 0.5 True 1 2 - + - + _Composer + False True True False - False True + 0.5 True 2 3 - + - + A_lbum + False True True False - False True + 0.5 True 3 4 - + _Year + False True True False - False True + 0.5 True 4 5 GTK_FILL - + _Last played + False True True False - False True + 0.5 True 1 2 GTK_FILL - + _Genre + False True True False - False True + 0.5 True 2 3 GTK_FILL - + Da_te added + False True True False - False True + 0.5 True @@ -340,17 +354,18 @@ 1 2 GTK_FILL - + _Play count + False True True False - False True + 0.5 True @@ -359,17 +374,18 @@ 2 3 GTK_FILL - + C_omment + False True True False - False True + 0.5 True @@ -378,17 +394,18 @@ 3 4 GTK_FILL - + _BPM + False True True False - False True + 0.5 True @@ -397,17 +414,18 @@ 4 5 GTK_FILL - + _Rating + False True True False - False True + 0.5 True @@ -416,17 +434,18 @@ 4 5 GTK_FILL - + Ti_me + False True True False - False True + 0.5 True @@ -435,17 +454,18 @@ 3 4 GTK_FILL - + Lo_cation + False True True False - False True + 0.5 True @@ -454,17 +474,18 @@ 2 3 GTK_FILL - + _Quality + False True True False - False True + 0.5 True @@ -473,12 +494,9 @@ 1 2 GTK_FILL - + - - - True diff --git a/data/ui/main-toolbar.ui b/data/ui/main-toolbar.ui index e6a9177b6..f05336384 100644 --- a/data/ui/main-toolbar.ui +++ b/data/ui/main-toolbar.ui @@ -1,6 +1,7 @@ + - + True False @@ -16,24 +17,32 @@ True False - 8 - 9 + 8 + 8 + 9 + 9 24 media-skip-forward-symbolic + 6 True False - 12 - 9 + 12 + 12 + 9 + 9 24 media-playback-start-symbolic + 6 True False - 8 - 9 + 8 + 8 + 9 + 9 24 media-skip-backward-symbolic @@ -53,9 +62,6 @@ False 6 6 - True @@ -65,7 +71,7 @@ image5 True @@ -82,7 +88,7 @@ app.play image4 @@ -99,7 +105,7 @@ app.play-next image3 @@ -108,6 +114,9 @@ 2 + @@ -127,9 +136,6 @@ True False - True @@ -138,7 +144,7 @@ app.play-repeat image2 @@ -155,7 +161,7 @@ app.play-shuffle image1 @@ -164,6 +170,9 @@ 1 + diff --git a/data/ui/podcast-prefs.ui b/data/ui/podcast-prefs.ui index 3bb6b054a..e50f04b37 100644 --- a/data/ui/podcast-prefs.ui +++ b/data/ui/podcast-prefs.ui @@ -1,21 +1,48 @@ - + + - - + + + + + + + + + + + Every hour + hourly + + + Every day + daily + + + Every week + weekly + + + Manually + manual + + + True + False + start 12 - vertical 18 - start True - vertical + False 6 True + False 0 Podcast Downloads @@ -31,9 +58,11 @@ True + False True + False False @@ -44,10 +73,13 @@ True + False True - 8 + False + 8 + 8 False @@ -58,6 +90,7 @@ True + False 2 2 12 @@ -65,6 +98,7 @@ True + False 0 _Download location: True @@ -73,12 +107,13 @@ GTK_FILL - + True + False 0 Check for _new episodes: True @@ -88,12 +123,13 @@ 1 2 GTK_FILL - + True + False interval-values @@ -113,15 +149,18 @@ True - vertical + False True + False select-folder True Select Folder For Podcasts + True + True 0 @@ -135,16 +174,22 @@ + True + True 1 + True + True 1 + True + True 1 @@ -156,30 +201,4 @@ - - - - - - - - - - Every hour - hourly - - - Every day - daily - - - Every week - weekly - - - Manually - manual - - - diff --git a/data/ui/sync-dialog.ui b/data/ui/sync-dialog.ui index ef3faf826..dab76ebcf 100644 --- a/data/ui/sync-dialog.ui +++ b/data/ui/sync-dialog.ui @@ -1,33 +1,34 @@ - + + - - + True + False 12 - vertical True + False 0 none True + False 12 - vertical True True - automatic - automatic in + True + True 0 @@ -36,6 +37,7 @@ True + False Sync Preferences @@ -44,21 +46,26 @@ + True + True 0 True + False 0 none True + False 12 True + False @@ -69,6 +76,7 @@ True + False Sync Preview @@ -78,21 +86,26 @@ False + True 1 True + False True - 6 + False + 6 + 6 gtk-dialog-error - 6 + 6 False + True 12 0 @@ -100,15 +113,19 @@ True + False 0 + True + True 1 False + True 6 2 diff --git a/widgets/rb-button-bar.c b/widgets/rb-button-bar.c index 3ca0ebbec..fb9bc748c 100644 --- a/widgets/rb-button-bar.c +++ b/widgets/rb-button-bar.c @@ -207,7 +207,7 @@ append_menu (RBButtonBar *bar, GMenuModel *menu, gboolean need_separator) label_text = NULL; g_menu_model_get_item_attribute (menu, i, "label", "s", &label_text); label = gtk_label_new (g_dgettext (NULL, label_text)); - g_object_set (label, "xpad", 6, NULL); + g_object_set (label, "margin-left", 6, "margin-right", 6, NULL); gtk_container_add (GTK_CONTAINER (button), label); if (g_menu_model_get_item_attribute (menu, i, "accel", "s", &accel)) {