Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add or move a warning regarding a failure to resolve space for marker #28

Open
angiehjort opened this issue Oct 28, 2020 · 1 comment
Open

Add or move a warning regarding a failure to resolve space for marker #28

angiehjort opened this issue Oct 28, 2020 · 1 comment

Comments

@angiehjort
Copy link
Member

there is a warning right after, but the code won't reach there because this line will crash and burn when space is null

https://github.com/vizabi/vizabi-reactive/blob/5e6fa9f3d4d0a464e1447bd928efa972aa48a9ca/src/core/dataConfig/dataConfig.js#L133
angiehjort added a commit that referenced this issue Oct 28, 2020
@angiehjort
Move a warning so it can be displayed before crash
61f6700 
Fixes #28
@angiehjort angiehjort mentioned this issue Oct 28, 2020
Closed
angiehjort added a commit that referenced this issue Feb 11, 2021
@angiehjort
Move a warning so it can be displayed before crash
706d771 
Fixes #28
@jheeffer
Copy link
Collaborator

jheeffer commented Mar 27, 2021 •
edited
Loading

Need to add tests to dataConfig/solver for how it fails on bad configs or impossible solver configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move a warning so it can be displayed before crash vizabi/core
2 participants
@jheeffer @angiehjort