From 79d1fd76085e84dbee2f50eeaffca2210d4ded1d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?oliver=20k=C3=B6nig?= Date: Tue, 12 Nov 2024 23:43:48 +0100 Subject: [PATCH] build: Add conda env to `$PATH` (#357) * build: Add conda env to `$PATH` Signed-off-by: Oliver Koenig * test Signed-off-by: Oliver Koenig * add newline Signed-off-by: Oliver Koenig * run cleanup always Signed-off-by: Oliver Koenig --------- Signed-off-by: Oliver Koenig Signed-off-by: Vinay Raman --- .github/workflows/gpuci.yml | 5 +++-- Dockerfile | 2 ++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/workflows/gpuci.yml b/.github/workflows/gpuci.yml index 315c5ebd..a48e79ef 100644 --- a/.github/workflows/gpuci.yml +++ b/.github/workflows/gpuci.yml @@ -70,7 +70,7 @@ jobs: # list all of our packages. Useful for debugging - name: Verify installations run: | - docker exec nemo-curator-container conda run -n curator pip list + docker exec nemo-curator-container pip list # In the virtual environment (called "curator") we created in the container, # run our PyTests marked with `@pytest.mark.gpu` @@ -78,11 +78,12 @@ jobs: # and then the directory where the PyTests are located - name: Run PyTests with GPU mark run: | - docker exec nemo-curator-container conda run -n curator pytest -m gpu --rootdir /opt/NeMo-Curator /opt/NeMo-Curator/tests + docker exec nemo-curator-container pytest -m gpu --rootdir /opt/NeMo-Curator /opt/NeMo-Curator/tests # After running `docker stop`, the container remains in an exited state # It is still present on our system and could be restarted with `docker start` # Thus, we use `docker rm` to permanently removed it from the system - name: Cleanup + if: always() run: | docker stop nemo-curator-container && docker rm nemo-curator-container diff --git a/Dockerfile b/Dockerfile index 642d1ec5..c4a8b46d 100644 --- a/Dockerfile +++ b/Dockerfile @@ -53,3 +53,5 @@ RUN bash -exu <