Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pSBC usage #13

Open
PimpTrizkit opened this issue Nov 21, 2019 · 0 comments
Open

pSBC usage #13

PimpTrizkit opened this issue Nov 21, 2019 · 0 comments

Comments

@PimpTrizkit
Copy link

Hey! I see you are making good use out of my pSBC function. That's awesome!

I just had one very minor thing to mention...

pSBC(0, chosenColor) doesn't do anything. Passing in 0 tells pSBC to not shade the color (ie. make no changes). So unless you are using it for reformatting the rgb() or HEX string, its just a waste of processor time and file size. I would think to remove those lines and just use chosenColor directly. It looks like this is done three times on lines 414, 445, and 450 in the color-indent-spec.js file.

Just an idea.

PT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant