You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey! I see you are making good use out of my pSBC function. That's awesome!
I just had one very minor thing to mention...
pSBC(0, chosenColor) doesn't do anything. Passing in 0 tells pSBC to not shade the color (ie. make no changes). So unless you are using it for reformatting the rgb() or HEX string, its just a waste of processor time and file size. I would think to remove those lines and just use chosenColor directly. It looks like this is done three times on lines 414, 445, and 450 in the color-indent-spec.js file.
Just an idea.
PT
The text was updated successfully, but these errors were encountered:
Hey! I see you are making good use out of my pSBC function. That's awesome!
I just had one very minor thing to mention...
pSBC(0, chosenColor)
doesn't do anything. Passing in0
tells pSBC to not shade the color (ie. make no changes). So unless you are using it for reformatting thergb()
or HEX string, its just a waste of processor time and file size. I would think to remove those lines and just usechosenColor
directly. It looks like this is done three times on lines 414, 445, and 450 in thecolor-indent-spec.js
file.Just an idea.
PT
The text was updated successfully, but these errors were encountered: