Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sudo user field required w/ a default #112

Open
mpdehaan opened this issue Jan 8, 2019 · 0 comments
Open

Make sudo user field required w/ a default #112

mpdehaan opened this issue Jan 8, 2019 · 0 comments

Comments

@mpdehaan
Copy link
Member

mpdehaan commented Jan 8, 2019

If the sudo user is left blank, confusing error messages can result, that would be more clear if we didn't allow it to be blank.

I am proposing the sudo_user field on the worker pool default to "vespene_build" and be set to be non-nullable.

This value will not be used if using basic_container isolation, but will still be used for sudo isolation, making it more clear to new users that they need to change the username when trying things out for the first time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant