Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TOML Support #49

Open
LyndonArmitage opened this issue Jun 21, 2018 · 5 comments
Open

TOML Support #49

LyndonArmitage opened this issue Jun 21, 2018 · 5 comments

Comments

@LyndonArmitage
Copy link

I've written a small library to add support for the TOML configuration format here using the toml4j library. Is there any interest in creating a pull request and adding this support to this project? It should only take a small amount of effort to add although I am unsure on how to test the code generation side of things.
@cescoffier
Copy link
Member

Oh yes, definitely welcome!

@rgmz
Copy link

rgmz commented Jul 17, 2018

I'd also love to see support for TOML, if you are still interested. 😃

@LyndonArmitage
Copy link
Author

Apologies for leaving this message then disappearing.
I shall work on a pull request as soon as I get a chance, hopefully some time this week.

@vietj
Copy link
Contributor

vietj commented Jul 17, 2018

thanks @LyndonArmitage that would be great

LyndonArmitage pushed a commit to LyndonArmitage/vertx-config that referenced this issue Sep 24, 2018
Add TOML support
050929d 
Addresses vert-x3#49

Using toml4j adds TOML support.

Note: I have used Jetbrains annotations in this commit, if that is not
desired I can remove them and stick with standard Java 8 methods of
ensuring method contracts when it comes to null values.
@LyndonArmitage LyndonArmitage mentioned this issue Sep 24, 2018
Open
@LyndonArmitage
Copy link
Author

Added PR. See #57

Need to be aware of what version(s) of the TOML Spec we add support for.

Apologies for the lengthy delay.

LyndonArmitage pushed a commit to LyndonArmitage/vertx-config that referenced this issue Sep 25, 2018
Remove Jetbrains annotations from Toml processor
8e100f1 
Change requested for vert-x3#49 by Clement Escoffier

Makes sense as do not gain a whole lot by having them present and they
add another dependency to the project.
LyndonArmitage pushed a commit to LyndonArmitage/vertx-config that referenced this issue Sep 25, 2018
Remove empty constructor from TOML processor
abc829b 
Change requested for vert-x3#49 by Clement Escoffier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@vietj @cescoffier @LyndonArmitage @rgmz