Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vercel): nested runs being unflattened, incorrect inheritance behavior of user runId / traceable #1383

Merged
merged 6 commits into from
Jan 8, 2025
Merged

fix(vercel): nested runs being unflattened, incorrect inheritance behavior of user runId / traceable #1383

merged 6 commits into from
Jan 8, 2025
+411 −260

Conversation

dqbd
Copy link
Collaborator

@dqbd dqbd commented Jan 7, 2025

@dqbd dqbd requested a review from jacoblee93 January 7, 2025 16:56
jacoblee93
jacoblee93 approved these changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@jacoblee93 jacoblee93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tests pass, have a few questions

js/src/vercel.ts Show resolved Hide resolved
js/src/vercel.ts Show resolved Hide resolved
js/src/vercel.ts Show resolved Hide resolved
js/src/vercel.ts Outdated Show resolved Hide resolved
@dqbd dqbd merged commit af5a931 into main Jan 8, 2025
12 checks passed
@dqbd dqbd deleted the dqbd/vercel-nested-runs-fix branch January 8, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacoblee93 jacoblee93 jacoblee93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Langsmith nested runs do not work correctly with streaming
2 participants
@dqbd @jacoblee93