Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links are not saved/propagating to other sites #219

Open
angelokeirsebilck opened this issue Dec 11, 2024 · 2 comments
Open

Links are not saved/propagating to other sites #219

angelokeirsebilck opened this issue Dec 11, 2024 · 2 comments

Comments

@angelokeirsebilck
Copy link

Describe the bug

I have a Hyper link field with multiple links enabled but the links saved in 1 site do not get propagated to the others sites resulting in my Hyper field i'm using for my main navigation is out of sync between two sites/languages.

So my Hyper field is set to multiple links enabled and my translation method is set to Translate for each site, as I want to be able to translate the Link Text on a per site/language basis. The only way to make the links sync between the sites is to choose another translation method, for example translate for each site group or do not translate but then I cannot change the Link Text on a per site basis.

I've made a video to help understand the problem.

hyper-links-not-propagated.mp4

Steps to reproduce

  1. Create a Multi site/language Craft CMS setup
  2. Create a Hyper link field with multiple links enable
  3. Set the translation method to Translate for each site
  4. Add links in site A
  5. Confirm they are not saved in the links in site B

Craft CMS version

Craft Pro 5.5.5

Plugin version

2.2.1

Multi-site?

Yes

Additional context

No response

@angelokeirsebilck
Copy link
Author

Hi @engram-design

Any update on this? Or is this not a bug?

As of now this is really time consuming (i've got 30+ sites), when changing the menu I have to change it on 30+ sites.

@engram-design
Copy link
Member

I was struggling to reproduce this one, but I think I've figured out the steps as per your video now.

However, this is a tricky one to cater for. Unlike the similar behaviour with Matrix, where each block is an element, knowing how to handle new links is a little tricky. We need to know if they're new in order to propagate them.

I'm looking into adding a flag for this when you create those links, there's just some complications with regard to saving these values. For example, what if the other site links have a different collection of links? There's no guarantee they're in the some order, the same amount or even the same links. Not to mention, we don't treat each link individually (e.g. we don't save them like Matrix elements), so we'll have to add handling for that.

But the short of it, is looking into it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants