Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Transaction can be approved in vega wallet before any transaction is submitted #9117

Open
daniel1302 opened this issue Aug 18, 2023 · 1 comment
Assignees
Milestone

Comments

@daniel1302
Copy link
Contributor

daniel1302 commented Aug 18, 2023

Problem encountered

Bug found in the vega wallet by Ed from the Validator group

Observed behaviour

Forwarded message from the Validators discord

I found an interesting "bug" in the CLI wallet. I guess it's less of a bug but if you hit y then enter while the wallet is idling and connected, next time you submit a tx it will get approved immediately, presumably because the y is still waiting in stdin and gets read as soon as the tx requires confirmation.

Expected behaviour

This needs to be discussed

Steps to reproduce

1. Start wallet
2. Press the "y" when no transaction needs to be approved
3. Send any transaction

Software version

v0.71.6 - ubuntu 22 amd64

Failing test

No response

Jenkins run

No response

Configuration used

No response

Relevant log output

No response

@ValentinTrinque
Copy link
Contributor

It's known.

@gordsport gordsport added this to the 🥶 Icebox milestone Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

3 participants