Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Increase timeout or add retry for downloading vega binaries in the visor after the protocol upgrade #10297

Open
daniel1302 opened this issue Dec 28, 2023 · 0 comments

Comments

@daniel1302
Copy link
Contributor

Problem encountered

We got an issue after the last protocol upgrade, where vega was unable to download vega binary and We got the following error:

Dec 28 10:02:13 be1.vega.community visor[1444236]: Error: failed to prepare next upgrade folder: failed to auto install folder "/home/vega/vegavisor_home/v0.73.10" for release "v0.73.10": failed to download release assets for tag "v0.73.10": failed to download asset "vega-linux-amd64.zip" of type "v0.73.10" for tag "application/zip": failed to read  "/home/vega/vegavisor_home/v0.73.10/vega-linux-amd64.zip": context deadline exceeded (Client.Timeout or context cancellation while reading body)

We should increase the timeout or add retry

Observed behaviour

As above.

Expected behaviour

Vegavisor can retry download and unzip vega binaries.

Steps to reproduce

1. Start the network
2. Make your network slow (add rate limit on the router)
3. Propose the protocol upgrade.

Software version

v0.73.9

Failing test

No response

Jenkins run

No response

Configuration used

No response

Relevant log output

Dec 28 10:00:11 be1.vega.community visor[1444236]: 2023-12-28T10:00:11.261Z        INFO        visor        visor/visor.go:192        Starting upgrade
Dec 28 10:00:11 be1.vega.community visor[1444236]: 2023-12-28T10:00:11.261Z        DEBUG        visor        visor/visor_folders.go:103        preparing next upgrade folder        {"vegaTagVersion": "v0.73.10"}
Dec 28 10:00:11 be1.vega.community visor[1444236]: 2023-12-28T10:00:11.262Z        INFO        visor        visor/visor_folders.go:57        Automatically installing upgrade folder
Dec 28 10:00:11 be1.vega.community visor[1444236]: 2023-12-28T10:00:11.280Z        INFO        visor        visor/visor_folders.go:78        Downloading asset from Github        {"asset": "vega-linux-amd64.zip"}
Dec 28 10:02:13 be1.vega.community visor[1444236]: Error: failed to prepare next upgrade folder: failed to auto install folder "/home/vega/vegavisor_home/v0.73.10" for release "v0.73.10": failed to download release assets for tag "v0.73.10": failed to download asset "vega-linux-amd64.zip" of type "v0.73.10" for tag "application/zip": failed to read  "/home/vega/vegavisor_home/v0.73.10/vega-linux-amd64.zip": context deadline exceeded (Client.Timeout or context cancellation while reading body)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

3 participants