Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Border #14

Open
Syndamia opened this issue Sep 29, 2020 · 6 comments
Open

Border #14

Syndamia opened this issue Sep 29, 2020 · 6 comments

Comments

@Syndamia
Copy link

Is there a way to generate the icons with borders? If not, is there a way to add that functionality?

@Souravgoswami
Copy link
Contributor

Souravgoswami commented Sep 29, 2020

Icons generally don't have borders yet, but yes, with a little bit of effort and time, that can be added.

@varlesh maybe add some borders if you have time? The the ruby script can again, control the border colour, opacity...

Edit: We can probably write an inkscape script which can automatically add border.

@Souravgoswami
Copy link
Contributor

Souravgoswami commented Sep 29, 2020

From my end, the cursor with borders is ready!

But unfortunately I have changed the syntax of the generator. It's not hard, but it's quite easier now! You don't have to remember patterns now.

For example:

purple = colour: #912BFF, label: #ff0, shadow: #000, shadow_opacity: 0.3, stroke: #08f, stroke_opacity: 1.2, stroke_width: 3

Generates this:
image

You can also use these syntaxes (case insensitive):

# "_" can be replaced with "-". For example, "stroke_opacity" can be written as "stroke-opacity".
# "colour" can be replaced with "color", For example, "colour: #55f" can be written as "color: #55f".
# ":" can be replaced with "=". For example, "stroke-width: 1" can be written as "stroke-width = 1".

# If you want to generate a single colour with the default value for others
# purple = #fff

No, don't give the 3 size to the border. Just 1 or 1.25 is good enough!
And yes, it works without breaking anything. If you don't need border, just don't set the stroke-width, which is 0 by default even if you passed colours.

@Souravgoswami
Copy link
Contributor

Souravgoswami commented Sep 29, 2020

I am yet afraid to merge it (to my branch) and send a PR here. I haven't tested all of them!
Would you like to help out a bit?

Please clone this branch:
https://github.com/Souravgoswami/oreo-cursors/tree/oreo-bordered

Here are the steps:

git clone https://github.com/Souravgoswami/oreo-cursors.git
cd oreo-cursors
git checkout oreo-bordered

If you just want to install the predefined coloured cursors, just run make install.


If you want to generate new cursors

  1. edit the configuration file
  2. generate the cursors that you like, add some borders with stroke, don't forget to set stroke-opacity, and stroke-width.

Note that I have came up with a new syntax for the configuration file for now, because it's hard to put the things in order! If requested this can be transferred to JSON or YAML.

  1. Run make build to build the cursors, then run make install. All can be done from the root directory of the project.

The make build now requires ruby. The generator won't overwrite already existing same files now!


And when all done, please leave a comment!

@Syndamia
Copy link
Author

Syndamia commented Sep 29, 2020

First of all, thank you a lot for the quick response and work!

Second of all, the border works flawlessly. I did some tests with the predefined cursors and with some custom ones I generated. I tested on my Linux Mint 20 Cinnamon desktop, but I will also test it on a bunch of other distros and machines (although it is pretty late right now, so I'll do it tomorrow ; I'll post with an update, of course).

If requested this can be transferred to JSON or YAML.

I don't think that is necessary, this syntax is pretty simple and self-explanatory!

Again, thank you for your speedy work and cooperation!

@Souravgoswami
Copy link
Contributor

Souravgoswami commented Sep 29, 2020

Thanks a lot! I will be sending pull request when everything is fixed and @varlesh has no problem with the commit...

@Syndamia
Copy link
Author

Syndamia commented Oct 1, 2020

Update: things got a bit complicated, so I was (and will be) only able to test it on Manjaro XFCE, where it worked flawlessly. I'll leave this issue opened, until the border is merged with the main branch.

Again, thank you for your work! I'm having a really good time with these cursors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants