Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider adding older engine versions (like 7.2) #5

Open
roshkhatri opened this issue Nov 28, 2024 · 3 comments
Open

Consider adding older engine versions (like 7.2) #5

roshkhatri opened this issue Nov 28, 2024 · 3 comments

Comments

@roshkhatri
Copy link
Member

roshkhatri commented Nov 28, 2024 •
edited
Loading

This can help in catching regressions.#1 (comment)
@roshkhatri roshkhatri mentioned this issue Nov 28, 2024
Merged
@joehu21 joehu21 self-assigned this Dec 10, 2024
joehu21 pushed a commit to joehu21/valkeyJSON that referenced this issue Dec 10, 2024
Fix valkey-io#5 - Consider adding older engine versions (like 7.2)
06ffb50
@joehu21
Copy link
Collaborator

joehu21 commented Dec 10, 2024 •
edited
Loading

Agreed we should use the tip of 8.0 and support 7.2. Should we also support 7.0 and 6.2?

@roshkhatri
Copy link
Member Author

I think we should only support 7.2 and above as valkey does not have releases for pre 7.2 version.

@joehu21
Copy link
Collaborator

joehu21 commented Dec 17, 2024

The issue depends on this backport PR: valkey-io/valkey#1413

@joehu21 joehu21 removed their assignment Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joehu21 @roshkhatri