GCC <=12 is incompatible - CI is biased

[metal3d]

Hi,

I tried to compile a container image with the module from valkey/valkey:8 (not yet on alpine).

A lot of errors happen.

I fixed this by downgrading GCC and G++ to v11.

Here is the Dockerfile that works:

FROM docker.io/valkey/valkey:8 as build

ARG SERVER_VERSION=8.0.0
RUN set -ex; \
  apt-get update; \
  apt-get install -y build-essential cmake git gcc-11 g++-11 pkg-config; \
  update-alternatives --install /usr/bin/gcc gcc /usr/bin/gcc-11 1; \
  update-alternatives --install /usr/bin/g++ g++ /usr/bin/g++-11 1; \
  mkdir -p /opt;

WORKDIR /opt
RUN set -ex; \
  git clone https://github.com/valkey-io/valkeyJSON.git; \
  mkdir -p /opt/valkeyJSON/build;

WORKDIR /opt/valkeyJSON/build
RUN set -ex; \
  cmake .. -DVALKEY_VERSION=${SERVER_VERSION}; \
  make

FROM docker.io/valkey/valkey:8
RUN mkdir -p /usr/lib/valkey
COPY --from=build /opt/valkeyJSON/build/src/libjson.so /usr/lib/valkey/libjson.so
CMD ["valkey-server", "--loadmodule", "/usr/lib/valkey/libjson.so"]

On Github Actions, Ubuntu version is not the latest, and not the one used by the main OCI Image. So the tests are OK on GitHub actions, but not with the official image.

[joehu21]

Thanks for opening the issue. Agreed we should fix this ASAP.

[metal3d]

BTW, it works great 😉

[roshkhatri]

Working on a fix, the ubuntu-latest runner has also started using ubuntu 24 and the default is version 13, which is why the test is failing

[metal3d]

For the moment, you can install gcc as I do in the example Dockerfile and use update-alternatives. That can fix the GH action until you fix the problem.