Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test Failure] Half-finish importing in tests/unit/cluster/half-migrated-slot.tcl #1526

Open
madolson opened this issue Jan 8, 2025 · 1 comment · May be fixed by #1532
Open

[Test Failure] Half-finish importing in tests/unit/cluster/half-migrated-slot.tcl #1526

madolson opened this issue Jan 8, 2025 · 1 comment · May be fixed by #1532
Assignees
@sarthakaggarwal97
Labels
test-failure An issue indicating a test failure

Comments

@madolson
Copy link
Member

madolson commented Jan 8, 2025 

Expected 'xyz' to be equal to '' (context: type source line 88 file /Users/runner/work/valkey/valkey/tests/unit/cluster/half-migrated-slot.tcl cmd {assert_equal "xyz" [$cluster get aga]} proc ::test)

I've seen this test failure before, but the most recent occurrence is: https://github.com/valkey-io/valkey/actions/runs/12661473464/job/35284721513.
@madolson madolson added the test-failure An issue indicating a test failure label Jan 8, 2025
@sarthakaggarwal97
Copy link
Contributor

I have seen this test to be flaky as well locally in mac

@sarthakaggarwal97 sarthakaggarwal97 self-assigned this Jan 8, 2025
@sarthakaggarwal97 sarthakaggarwal97 linked a pull request Jan 8, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sarthakaggarwal97 sarthakaggarwal97

Labels
test-failure An issue indicating a test failure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix flakly half-finish importing cluster test sarthakaggarwal97/valkey
2 participants
@sarthakaggarwal97 @madolson