Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory tracking #24

Closed
yairgott opened this issue Jan 23, 2025 · 2 comments
Closed

Fix memory tracking #24

yairgott opened this issue Jan 23, 2025 · 2 comments
Milestone
Version 1.0

Comments

@yairgott
Copy link
Collaborator

Memory tracking broke after porting the code to the new OS. A BAZEL_BUILD macro was introduced, which disables the following unittests:

  1. vmsdk/testing/memory_allocation_test.cc
  2. testing/valkey_search_test.cc
@yairgott yairgott added this to the Version 1.0 milestone Jan 23, 2025
@yairgott
Copy link
Collaborator Author

#22 might be related.

@yairgott
Copy link
Collaborator Author

Fixed with the following commit: 8ca35b5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 1.0
Development

No branches or pull requests
1 participant
@yairgott