Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node: add module testing CI #2431

Closed
1 of 2 tasks
Yury-Fridlyand opened this issue Oct 11, 2024 · 1 comment · Fixed by #2472
Closed
1 of 2 tasks

Node: add module testing CI #2431

Yury-Fridlyand opened this issue Oct 11, 2024 · 1 comment · Fixed by #2472
Assignees
@tjzhang-BQ
Labels
CI/CD CI/CD related node Node.js wrapper
Milestone
1.2

Comments

@Yury-Fridlyand
Copy link
Collaborator

Describe the feature

  • Add CI which runs modules tests only
  • Add basic tests which validates connectivity and installed modules
  • Ensure that these tests don't run in regular IT
  • Update dev docs

Use Case

Modules IT

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

Client version used

N/A

Environment details (OS name and version, etc.)

N/A
@Yury-Fridlyand Yury-Fridlyand added node Node.js wrapper CI/CD CI/CD related 1_2_candidate labels Oct 11, 2024
@Yury-Fridlyand Yury-Fridlyand added this to the 1.2 milestone Oct 11, 2024
@tjzhang-BQ tjzhang-BQ mentioned this issue Oct 17, 2024
Merged
6 tasks
@tjzhang-BQ
Copy link
Collaborator

completed in the above mentioned PR

@github-project-automation github-project-automation bot moved this from In Progress to Done in Valkey-GLIDE - internal Oct 18, 2024
@Yury-Fridlyand Yury-Fridlyand linked a pull request Oct 18, 2024 that will close this issue
Node: Add CI support for server modules #2472
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tjzhang-BQ tjzhang-BQ

Labels
CI/CD CI/CD related node Node.js wrapper
Projects
Valkey-GLIDE - internal
Status: Done
Milestone
1.2
Development

Successfully merging a pull request may close this issue.

Node: Add CI support for server modules valkey-io/valkey-glide
2 participants
@Yury-Fridlyand @tjzhang-BQ