Liquip.Patcher.Build - Compile dll using NativeAOT

[valentinbreiz]

• Needs an entrypoint (using csharp source) and dll references for kernel / plugs

[valentinbreiz]

Blocked by #23

[kumja1]

Blocked by #23

Fixed by #25

[Guillermo-Santos]

Will this be it's own repo? as i see it was removed from the main branch

[valentinbreiz]

Will this be it's own repo? as i see it was removed from the main branch

No, it will be a part of Liquip.Patcher.Build. You can take a look at https://github.com/valentinbreiz/nativeaot-patcher/blob/main/src/Liquip.Patcher.Build/Build/Build.props, it will be added there I think.

@zarlo could you confirm this?

[zarlo]

okay for the sdk project i think it should be in the cosmos name space

for the tasks that call ilc i think it should have its own nuget package: Liquip.ilc.Build doing this will allow other projects to use out plug system in a simple manner

the sdk nuget package should use Liquip.Patcher.Build and Liquip.ilc.Build

some context: #33

[Guillermo-Santos]

for the tasks that call ilc i think it should have its own nuget package: Liquip.ilc.Build doing this will allow other projects to use out plug system in a simple manner

I guess Liquip.ilc.Build referenceLiquip.Patcher.Build, right?

But, if Liquip.ilc.Build will only be used on Cosmos, then it's Targets could be directly on the sdk.

[zarlo]

guess Liquip.ilc.Build referenceLiquip.Patcher.Build, right?

it can but it should not been to

But, if Liquip.ilc.Build will only be used on Cosmos, then it's Targets could be directly on the sdk.

i dont think we should do that, i will not stop it but it does mean the compiler will be more likely to be tied to Cosmos

[Guillermo-Santos]

Should the patcher put it's output on a distinctive folder (like $(OutputPath)/liquid)? i wondering how Liquip.ilc.Build would get it's input for ilc and the linker, if they would be independent.

[zarlo]

Should the patcher put it's output on a distinctive folder (like $(OutputPath)/liquid)? i wondering how Liquip.ilc.Build would get it's input for ilc and the linker, if they would be independent.

yes it should be some where in the obj folder

[kumja1]

Are we doing Liquip.ilc.Build and Liquip.Patcher.Build or for now just Liquip.Patcher.Build

[Guillermo-Santos]

Are we doing Liquip.ilc.Build and Liquip.Patcher.Build or for now just Liquip.Patcher.Build

Liquip.Patcher.Build will put it's output on a directory (inside obj as Zarlo Suggest) then Liquip.ilc.Build will take it.
The start of Liquid.ilc.Build may be done on this weekend.

[Guillermo-Santos]

As for publishing... i do not know if we should override the inputs when using true or we just disable publish aot and do the same as building.

[valentinbreiz]

Work in progress in #43