"Add pie build mode to all binary builds" not work as it described

[dyhkwong]

related commit: 8191faa

v2ray-core/.github/workflows/release.yml

Lines 131 to 144 in cab66de

	- name: Build V2Ray
	run: |
	mkdir -p build_assets
	EXTRA_ARG=""
	case "$GOOS-$GOARCH" in
	"linux-386")
	;&
	"linux-amd64")
	;&
	"linux-arm64")
	EXTRA_ARG=EXTRA_ARG+"-buildmode=pie"
	;;
	esac
	go build -v -o build_assets/v2ray -trimpath -ldflags "-s -w -buildid=" ./main

EXTRA_ARG does not get passed to go build. So it does not build with -buildmode=pie.

GOARCH='amd64' GOOS='linux' GOVERSION='go1.23.2', build v5.21.0 without -buildmode=pie:

$ CGO_ENABLED=0 go build -v -o v2ray -trimpath -ldflags "-s -w -buildid=" ./main
$ sha256sum v2ray 
fb5354aa11d3361280af9ffc0aa5acfe316337e82bfe01707bc483e3a123fef2  v2ray

Without -buildmode=pie, the hash of the binary matches the one of v5.21.0 release.

GOARCH='amd64' GOOS='linux' GOVERSION='go1.23.2', build v5.21.0 with -buildmode=pie:

$ CGO_ENABLED=0 go build -v -o v2ray -trimpath -ldflags "-s -w -buildid=" -buildmode=pie ./main
$ sha256sum v2ray 
94b193f4375d64bb636ed1e78ff874820dd1818effb7f010082474bc408aed66  v2ray

[dyhkwong]

Fixed by #3281.

[dyhkwong]

Not fixed yet. In #3281, builds with PIE and without PIE have the same file name (v2ray-linux-64.zip, v2ray-linux-arm64-v8a.zip), only one of them will be uploaded.