Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showing large EArrays is slow #86

Closed
laborleben opened this issue Oct 19, 2017 · 4 comments
Closed

Showing large EArrays is slow #86

laborleben opened this issue Oct 19, 2017 · 4 comments

Comments

@laborleben
Copy link
Contributor

Showing large EArray is pretty slow since the buffer is not used and the whole EArray is loaded on each access.

laborleben added a commit to laborleben/ViTables that referenced this issue Oct 19, 2017
@uvemas
Copy link
Owner

uvemas commented Oct 20, 2017

Thanks for your report. Yes, I know that displaying large EArrays is slow, but an EArray is a somewhat difficult object. For instance, your suggested PR fails to show all array elements if the shape is something like (2, 0, 3), where 0 indicates the enlargable dimension. If you can rework your PR so that it works for that kind of shapes I will be really happy merging it.

@laborleben
Copy link
Contributor Author

OK, I understand. I fixed it in the PR. I tested with shapes (2,3,0), (2,0,3), (0,),with StringAtom and UIntAtom, and multiple lengths (zero length to pretty huge arrays). Seems to work for me. Someone adding unit tests would be also great.

uvemas added a commit that referenced this issue Oct 20, 2017
Fixing #86 (showing large EArrays)
@uvemas
Copy link
Owner

uvemas commented Oct 20, 2017

Wow! You've been really fast! Many thanks for your PR. And yes, you are right about unit tests. The whole ViTables lacks of unit tests. I'm working on them, but the work progresses slowly.

@uvemas uvemas closed this as completed Oct 20, 2017
@laborleben
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants