Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Lagoon in all Lagoon CLI Containers #726

Open
Schnitzel opened this issue Dec 13, 2019 · 7 comments
Open

Install Lagoon in all Lagoon CLI Containers #726

Schnitzel opened this issue Dec 13, 2019 · 7 comments
Assignees

Comments

@Schnitzel
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Feature Request

Describe the solution you'd like
Have lagoon cli already installed in all CLI Images of Lagoon

@GROwen
Copy link

GROwen commented Jul 9, 2020

This would be great for a whole bunch of reasons. The primary one I'm after is being able to trigger a Drush_sql-dump task during the pre-deploy step so that the backup is available via the UI.

Our project currently has a solution to dump this to the filesystem but we have vendors who would appreciate access via the UI.

@bomoko bomoko self-assigned this Aug 27, 2020
@vincenzodnp
Copy link
Contributor

What is the best option in your opinion:

@Schnitzel
Copy link
Contributor Author

@vincenzodnp I wrote my opinion in the first comment already, plus also in the header of this issue.

Have lagoon cli already installed in all CLI Images of Lagoon

Not sure why we would install it only in the toolbox? as the toolbox is not used by customers it wouldn't really help them?

@twardnw
Copy link
Contributor

twardnw commented Sep 23, 2020

Yes, installed in CLI images so that it is easy for customers to use

@bomoko
Copy link
Contributor

bomoko commented Sep 29, 2020

@shreddedbacon - so I started playing around with this inside the containers and it looks like, by default the dynamically linked binaries don't work straight (at least in alpine).

Building statically, it works just peachy. I wonder if it doesn't make sense to do a static release to support people running the cli inside containers?

@shreddedbacon
Copy link
Member

@shreddedbacon - so I started playing around with this inside the containers and it looks like, by default the dynamically linked binaries don't work straight (at least in alpine).

Building statically, it works just peachy. I wonder if it doesn't make sense to do a static release to support people running the cli inside containers?

@bomoko definitely. If you want to submit a PR to update the Makefile to support static builds, I'm down for it.

@tobybellwood tobybellwood transferred this issue from uselagoon/lagoon-cli Apr 13, 2023
@tobybellwood
Copy link
Member

This is still planned, but are wary that inserting it into every* container might cause unwanted impacts to users who don't deploy regularly. We can provide instructions on how best to achieve it in a project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants