Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An error in a mariadb docker-entrypoint-initdb.d script does not throw an error or fail the init #412

Open
rocketeerbkw opened this issue Mar 1, 2022 · 2 comments

Comments

@rocketeerbkw
Copy link
Member

A buggy migration for the lagoon api-db caused initialization of the database to end up in a bad state and fail the tests. It took a lot longer to figure out the error was a migration because the initialization didn't error out, it just caused a reboot (and at that point the data dir exists so it doesn't run migrations a second time).

I expect that a if a SQL statement fails, the mariadb init should also fail.

@smlx
Copy link
Member

smlx commented Mar 1, 2022

Would this also be fixed by using proper migrations and versioning of the DB schema as per uselagoon/lagoon#2995 ?

@rocketeerbkw
Copy link
Member Author

Yes, this won't be a problem for the api-db in the long term, but that still leaves the underlying issue there to ruin the day for other users of this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants