Skip to content
This repository has been archived by the owner on Jun 2, 2023. It is now read-only.

option to disable haveibeenpwned api #643

Closed
lachlan-00 opened this issue Jul 13, 2021 · 2 comments
Closed

option to disable haveibeenpwned api #643

lachlan-00 opened this issue Jul 13, 2021 · 2 comments
Labels
wontfix Problem, or not; this won't be fixed here at least.

Comments

@lachlan-00
Copy link

I can't use the internet where i'm installing passcore and it looks to me that it's required for the password hash search

https://github.com/unosquare/passcore/blob/master/src/PwnedPasswordsSearch/PwnedSearch.cs

it's also a bad idea to log any exception (like lack of internet) as a failure. this makes non-internet installs useless without manually rebuilding

@simonai1254
Copy link

Please have a look at #605, this should be related to you issue. I did downgrade to 4.2.3 to not need to rebuild the solution...

@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix Problem, or not; this won't be fixed here at least. label Apr 16, 2022
@stale stale bot closed this as completed Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
wontfix Problem, or not; this won't be fixed here at least.
Projects
None yet
Development

No branches or pull requests

2 participants