From 9cfe4aeea7b437f2a2486e369b99fcf75c5cfea9 Mon Sep 17 00:00:00 2001
From: David <github.site@torick.net>
Date: Fri, 13 Dec 2024 17:09:32 -0500
Subject: [PATCH] chore: Apply code review comments

---
 src/Directory.Build.props                                     | 2 --
 .../Uno.UI.SourceGenerators.Tests.csproj                      | 4 ++--
 src/Uno.UI.Tests/Uno.UI.Unit.Tests.csproj                     | 3 ++-
 src/Uno.UI/Uno.UI.Tests.csproj                                | 3 ---
 4 files changed, 4 insertions(+), 8 deletions(-)

diff --git a/src/Directory.Build.props b/src/Directory.Build.props
index 9f737fd6ddca..fc0c0e4e5464 100644
--- a/src/Directory.Build.props
+++ b/src/Directory.Build.props
@@ -226,8 +226,6 @@
 		
 		<!-- Required for studio -->
 		<NoWarn>$(NoWarn);UNO0008</NoWarn>
-		
-		<NoWarn>$(NoWarn);NU1903</NoWarn>
 
 		<!-- On CI, UWP source is generated in a job running on Windows (CRLF EOLs). -->
 		<!-- When the artifacts are downloaded in a job running on Linux, IDE0055 will complain (expecting LF EOLs) -->
diff --git a/src/SourceGenerators/Uno.UI.SourceGenerators.Tests/Uno.UI.SourceGenerators.Tests.csproj b/src/SourceGenerators/Uno.UI.SourceGenerators.Tests/Uno.UI.SourceGenerators.Tests.csproj
index 604138751e1e..fad382f237a4 100644
--- a/src/SourceGenerators/Uno.UI.SourceGenerators.Tests/Uno.UI.SourceGenerators.Tests.csproj
+++ b/src/SourceGenerators/Uno.UI.SourceGenerators.Tests/Uno.UI.SourceGenerators.Tests.csproj
@@ -1,11 +1,11 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">
 
 	<PropertyGroup>
 		<!-- There is no need to multi-target this test project -->
 		<!-- We keep it on the oldest supported TFM -->
 		<!-- Though we could use UnoTargetFrameworkOverride to choose between NetPrevious and NetCurrent -->
 		<!-- As of writing this comment, we don't see a need to do that, so we keep it simple -->
-		<TargetFramework>net9.0</TargetFramework>
+		<TargetFramework>$(NetCurrent)</TargetFramework>
 		<IsPackable>false</IsPackable>
 		<Nullable>enable</Nullable>
 		<ImplicitUsings>enable</ImplicitUsings>
diff --git a/src/Uno.UI.Tests/Uno.UI.Unit.Tests.csproj b/src/Uno.UI.Tests/Uno.UI.Unit.Tests.csproj
index b0a774c435a9..005db7a7af2f 100644
--- a/src/Uno.UI.Tests/Uno.UI.Unit.Tests.csproj
+++ b/src/Uno.UI.Tests/Uno.UI.Unit.Tests.csproj
@@ -12,10 +12,11 @@
 	</PropertyGroup>
 	<!--
 	Uncomment to troubleshoot source generation
-	-->
 	<PropertyGroup>
+		<UnoUISourceGeneratorDebuggerBreak>True</UnoUISourceGeneratorDebuggerBreak>
 		<EmitCompilerGeneratedFiles>true</EmitCompilerGeneratedFiles>
 	</PropertyGroup>
+	-->
 	<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
 		<DebugSymbols>true</DebugSymbols>
 		<DebugType>full</DebugType>
diff --git a/src/Uno.UI/Uno.UI.Tests.csproj b/src/Uno.UI/Uno.UI.Tests.csproj
index 33236d4c28d8..bcfb034cfc59 100644
--- a/src/Uno.UI/Uno.UI.Tests.csproj
+++ b/src/Uno.UI/Uno.UI.Tests.csproj
@@ -6,9 +6,6 @@
 	</PropertyGroup>
 
 	<Import Project="../targetframework-override.props" />
-	<PropertyGroup>
-		<EmitCompilerGeneratedFiles>true</EmitCompilerGeneratedFiles>
-	</PropertyGroup>
 
 	<PropertyGroup>
 		<AssemblyName>Uno.UI</AssemblyName>