Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Authentication][MSAL] Add back support for auth through WAM #2654

Closed
kazo0 opened this issue Jan 7, 2025 · 2 comments · Fixed by #2659
Closed

[Authentication][MSAL] Add back support for auth through WAM #2654

kazo0 opened this issue Jan 7, 2025 · 2 comments · Fixed by #2659
Assignees
Labels
area/authentication kind/regression Something was working, now it isn't

Comments

@kazo0
Copy link
Contributor

kazo0 commented Jan 7, 2025

Afaik opening the account picker in the default browser is the recommended approach as per the latest security standards (instead of the embedded browser) - the docs say so quite overwhelmingly as well - https://learn.microsoft.com/en-us/entra/msal/dotnet/acquiring-tokens/using-web-browsers#embedded-web-view-vs-system-browser

Correct for a browser based approach - however the desired and recommended behavior on Windows is to use the native WAM, which is built into the OS:
https://learn.microsoft.com/en-us/entra/msal/dotnet/acquiring-tokens/desktop-mobile/wam

Using the native Windows WAM was the behavior up to Uno.Sdk 5.2.139, which was broken in 5.2.175; that is what I referred to in this issue:

Expected behavior
I can update to the latest stable Uno Sdk and continue to use the native account picker on Windows with the Uno Auth Extensions.

Originally posted by @VincentH-Net in #2443 (comment)

Allow the MSAL Auth Extensions to be configured to use the WAM (https://learn.microsoft.com/en-us/entra/msal/dotnet/acquiring-tokens/desktop-mobile/wam). This will require a change to the IApplicationBuilder flow so that the instance of the main application Window can be retrieved and passed to .WithParentActivityOrWindow

@kazo0
Copy link
Contributor Author

kazo0 commented Jan 9, 2025

Follow these comments: #2631 (comment)

We should be replacing the PackageReference for Microsoft.Identity.Client.Desktop with Microsoft.Identity.Client.Broker

@kazo0
Copy link
Contributor Author

kazo0 commented Jan 9, 2025

Fix for this should be backported to release/stable/5.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/authentication kind/regression Something was working, now it isn't
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants