Non-text phrase types

[localstatic]

It would be helpful if Copywriting would support non-text phrase types (e.g. images, resources, etc).

I understand if this goes too far from the intended purpose of the extension, but it seems like Copywriting might be the best of the existing extensions for adding extra metadata to pages, and this new functionality would be extremely helpful.

[localstatic]

I am working on this for my current project. So far, I have already implemented image phrases, and it works well. I may need some other types as well before I'm done (e.g. boolean). If this is functionality that would be useful and wanted in Copywriting, I would be happy to open a pull request when I'm done. If not, i can just use my customized version for this project.

Let me know...

[unixcharles]

Hi @localstatic, thanks for the feedback. You could do it using phrase_type options set to wysiwyg.

Its not as slick but it would work. If you come up with a better solution, pull request are welcome. I'm just not sure of what would happen with the semantic. It would be a bit confusing to have a phrase that is actually an image lol.

[localstatic]

That semantic issue was exactly my reservation about this change. I have implemented image phrases using phrase_type=image, and it does work. I added logic for that to the value_field partial, so there's even an image picker. It's pretty slick, I think, but it just doesn't fit with the name ;)

Anyway, here's my branch if you're interested in checking it out: https://github.com/localstatic/refinerycms-copywriting/tree/new-phrase-types.

I'll submit a pull request when I'm done (I may only need the image type afterall, so that may be soon). If you want to merge it, great. If you decide it's not a good fit, I will harbor no hard feelings.

[localstatic]

To wrap this up, I've decided that this change is bigger than originally thought. The new phrase types work when the phrase is attached to a particular page, but otherwise, there is a clash between the global phrase edit UI's dialog and the image picker dialog that is used for an "image" phrase.

I'm wrapping up my project, and frankly am exhausted with Refinery, so I don't think I'll be pursuing this any further. If you want to use my changes and find a solution for the dialog conflict, that would be awesome. It may not be worth the effort though, and I'll totally understand if you close this issue as wontfix.

Thanks for the great extension. It's one of the few that I really was glad to have available, and it saved me a lot of work.

[unixcharles]

No problem, I might look into it later. Thanks for sharing.