Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The addresses for Bitcoin testnet is incorrect. #172

Open
chaoticlonghair opened this issue Apr 9, 2024 · 7 comments
Open

The addresses for Bitcoin testnet is incorrect. #172

chaoticlonghair opened this issue Apr 9, 2024 · 7 comments

Comments

@chaoticlonghair
Copy link

Description

After comparison with many other Bitcoin wallets, I found that the addresses for Bitcoin testnet which generated by UniSat wallet is different with others; such as Electrum, Sparrow and so on.

I think the derivation path which UniSat wallet used is incorrect.

Please read this section of BIP-0044:

  • The derivation path for Bitcoin testnet should be m / ${N}' / 1' / 0' / 0 / 0 .
  • But in UniSat wallet, the format of derivation paths for Bitcoin testnet is m / ${N}' / 0' / 0' / 0 / 0 .
@nardholio
Copy link

Not only is it incorrect, if you do send coins to them they show a zero balance in the UI. I think they're gone forever.

@GGG888GGG
Copy link
Collaborator

yes, we used different derivation path.
you could restore the same testnet address with custom path as below, when restore.
image @yangby-cryptape

@GGG888GGG
Copy link
Collaborator

@nardholio about the balance issue, sometimes the indexer indeed has some issue, you could report to us, our dev will fix it asap.

@nardholio
Copy link

@nardholio about the balance issue, sometimes the indexer indeed has some issue, you could report to us, our dev will fix it asap.

it eventually showed up. took almost a day though

@chaoticlonghair
Copy link
Author

we used different derivation path.

So, can I just say Unisat wallet is NOT a BIP-compatible wallet.

you could restore the same testnet address with custom path as below, when restore.

Also, I can do it with other wallets, or I could write my own code to use that wallet.


No offense intended, I just wanted to emphasize that this non-standard are dangerous for users who don't understand the technical details.

A bit irresponsible.


I have no more question, you can close this issue.

@slient-coder
Copy link
Contributor

We have noticed this issue, and we are looking for the right time to make adjustments. We hope to be compatible with BIP-0044 while maintaining the previous address format.

@happysammy
Copy link

I am encountering the same issue as previously reported, and it remains unresolved, which is concerning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants