Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yarn Mappings Causes Modern Forge Runs to Fail! #2

Closed
wagyourtail opened this issue Dec 19, 2022 · 4 comments
Closed

Yarn Mappings Causes Modern Forge Runs to Fail! #2

wagyourtail opened this issue Dec 19, 2022 · 4 comments
Labels
bug Something isn't working 🤦 forge help wanted I spent a day on it and still can't figure it out priority: medium breaks something in dev

Comments

@wagyourtail
Copy link
Collaborator

this is weird...

devrun.log
@wagyourtail wagyourtail added bug Something isn't working help wanted I spent a day on it and still can't figure it out priority: medium breaks something in dev labels Dec 19, 2022
@wagyourtail
Copy link
Collaborator Author

wagyourtail commented Jul 25, 2023 •
edited
Loading

ok. I'm a bit confused by java bytecode/classload stuff....

this is the same on forge/fabric, but one crashes and the other doesn't??????

LivingEntity.class
image

MobEntity.class
image

mojmap -> yarn
net.minecraft.entity.LivingEntity -> net.minecraft.world.entity.LivingEntity
net.minecraft.entity.Mob -> net.minecraft.world.entity.mob.MobEntity

why does this work on fabric tho...

@wagyourtail
Copy link
Collaborator Author

wagyourtail commented Jul 25, 2023 •
edited
Loading

ok. so it's not supposed to be able to access the protected method since it's in another package... and tiny remapper didn't fix that access, but still, why doesn't this crash on fabric loader

@wagyourtail
Copy link
Collaborator Author

ahh... FabricMC/tiny-remapper#92

@wagyourtail
Copy link
Collaborator Author

fixed in 186bd98

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working 🤦 forge help wanted I spent a day on it and still can't figure it out priority: medium breaks something in dev
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wagyourtail