Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using goimports to keep our imports well formed #956

Open
4 tasks
brianosaurus opened this issue May 25, 2022 · 1 comment
Open
4 tasks

Consider using goimports to keep our imports well formed #956

brianosaurus opened this issue May 25, 2022 · 1 comment

Comments

@brianosaurus
Copy link
Contributor

Summary

goimports is a tool that will keep our imports clean. We could use it to automatically add or remove imports where needed.

Problem Definition

This is a tool to keep imports consistent. Some of our imports are not in order at the moment. This tool would fix these items.

https://pkg.go.dev/golang.org/x/tools/cmd/goimports

Proposal

Add goimports to our Makefile so that it is run when we perform a build of our daemon. See the Axelar Makefile for an example:

https://github.com/axelarnetwork/axelar-core/blob/main/Makefile#L41


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@robert-zaremba
Copy link
Member

goimports is part of https://github.com/golangci/golangci-lint - so we should just update the config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants