x/leverage: Update ADRs to reflect implementations #897
Comments
|
Notably ADR-07 (bad debt) must be updated.
|
18 tasks
mergify bot
pushed a commit
that referenced
this issue
May 18, 2022
## Description + updated ADR 05 (liquidation) document + renamed `CalculateLiquidationLimit` -> `CalculateLiquidationThreshold`. The function return the maximum amount in USD we can borrow. Not a limit of a liquidation. + Updated error messages and style. related to: #897 ---- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added appropriate labels to the PR - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/umee-network/umee/blob/main/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
|
During the workshop we were talking about documentation issues, could you plan for this task in the next sprint (add check list of what to do and add them to the Linear)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ADRs haven't been touched since
proposedphase, with new changes appearing instead in the code and the spec.However, the availability of outdated information has caused confusion so we should update/clean/simplify them.
The text was updated successfully, but these errors were encountered: