Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: add cosmwasm handler for native modules to app #1686

Closed
wants to merge 10 commits into from
Closed

feat!: add cosmwasm handler for native modules to app #1686

wants to merge 10 commits into from

Conversation

gsk967
Copy link
Collaborator

@gsk967 gsk967 commented Jan 5, 2023 •
edited
Loading

Description

Adding leverage, oracle queries into cosmwasm handler

closes: #1191

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@gsk967 gsk967 marked this pull request as ready for review January 6, 2023 18:45
@gsk967 gsk967 requested a review from a team as a code owner January 6, 2023 18:45
robert-zaremba
robert-zaremba reviewed Jan 6, 2023
View reviewed changes
Copy link
Member

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. I left few suggestions

app/wasm/msg/handle_leverage.go Outdated Show resolved Hide resolved
app/wasm/msg/plugin.go Outdated Show resolved Hide resolved
app/wasm/query/plugin.go Outdated Show resolved Hide resolved
@gsk967
Copy link
Collaborator Author

gsk967 commented Jan 10, 2023

@robert-zaremba We will keep each module msgs and queries separately for cosmwasm handler, it is easy to handle check them

@gsk967 gsk967 requested a review from robert-zaremba January 10, 2023 11:29
@stale
Copy link

stale bot commented Mar 15, 2023

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the S:Stale label Mar 15, 2023
@stale stale bot closed this Mar 23, 2023
@robert-zaremba robert-zaremba deleted the sai/cosmwasm_handler branch April 30, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robert-zaremba robert-zaremba Awaiting requested review from robert-zaremba

Assignees
No one assigned
Labels
S:Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cosmwasm: (HAL-03) NEW QUERIES ARE NOT ADDED INTO THE HANDLER
3 participants
@gsk967 @robert-zaremba @adamewozniak