LTD-5948: Add option to make approval recommendation for F680 application #2379
+938
−90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment only approve option is available but will be extended later
The forms are duplication for F680 with the idea that they may differ from SIELs
We need to enclose the action buttons with rules etc but that will follow in later patches
saruniitr
commented
Feb 26, 2025
saruniitr
commented
Feb 26, 2025
Comment on lines
+13
to
+14
|
|
||
|
|
There was a problem hiding this comment.
These forms are created separately for F680 with the idea they can be different following user feedback once they see initial version.
saruniitr
commented
Feb 26, 2025
Comment on lines
+40
to
+41
| def post_approval_recommendation(request, case, data, level="user-advice"): | ||
| json = [ |
There was a problem hiding this comment.
Same here, some of these are same as advice function but unlike SIELs we are only going to create one Advice instance for F680 so some of these helper functions will be different.
saruniitr
force-pushed
the
LTD-5948-F680-select-recommendation-type
branch
from
8eb8e63 to
66d064b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
Add option to make approval recommendation for F680.
This is based on recommendation flow for SIEL where user can either approve/refuse all. Currently only approve option is presented.
When making recommendation we pull approval text (picklists) corresponding to the team. User can optionally enter provisos etc and submit recommendation. We then show the given recommendation details.
Currently any user can make a recommendation but this needs to be enclosed in a rule which will be done in subsequent PRs. This is mainly to limit the size of PR.
The option is add recommendation is not exposed to the user. It can only be accessed using the URL.
LTD-5948