From f8368806c87f2763705528829538988dc31c8ffc Mon Sep 17 00:00:00 2001
From: Michal Charemza <michal@charemza.name>
Date: Wed, 22 May 2024 16:17:47 +0100
Subject: [PATCH] feat: support for a second MLFlow to store artefacts in a
 bucket

This adds support to the VPC endpoint configuration for a second MLFlow
instance to access its bucket.

It's not great that the number is hard coded to 2 - others parts of the
Terraform support 0 or more. However, leaving that tidy up to further work
since it was already hard coded (to 1), and so not a meaningful step backwards.
---
 infra/ecs_notebooks_notebook.tf | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/infra/ecs_notebooks_notebook.tf b/infra/ecs_notebooks_notebook.tf
index d9a7e8f..25c7791 100644
--- a/infra/ecs_notebooks_notebook.tf
+++ b/infra/ecs_notebooks_notebook.tf
@@ -260,6 +260,7 @@ data "aws_iam_policy_document" "aws_vpc_endpoint_s3_notebooks" {
     resources = [
       "${aws_s3_bucket.notebooks.arn}",
       "${aws_s3_bucket.mlflow[0].arn}",
+      "${aws_s3_bucket.mlflow[1].arn}",
     ]
   }
 
@@ -278,6 +279,7 @@ data "aws_iam_policy_document" "aws_vpc_endpoint_s3_notebooks" {
     resources = [
       "${aws_s3_bucket.notebooks.arn}/*",
       "${aws_s3_bucket.mlflow[0].arn}/*",
+      "${aws_s3_bucket.mlflow[1].arn}/*",
     ]
   }
 
@@ -294,6 +296,7 @@ data "aws_iam_policy_document" "aws_vpc_endpoint_s3_notebooks" {
 
     resources = [
       "${aws_s3_bucket.mlflow[0].arn}",
+      "${aws_s3_bucket.mlflow[1].arn}",
     ]
   }